[SYCL] Fix triple in offload mismatch warning#10385
Merged
AlexeySachkov merged 2 commits intointel:syclfrom Jul 28, 2023
Merged
[SYCL] Fix triple in offload mismatch warning#10385AlexeySachkov merged 2 commits intointel:syclfrom
AlexeySachkov merged 2 commits intointel:syclfrom
Conversation
When standardizing the triples the format should be: ``` <arch><sub>-<vendor>-<sys>-<env> ``` * https://clang.llvm.org/docs/CrossCompilation.html#target-triple And then we add our offload arch afterwards, so the final triples should look something like: `nvptx64-nvidia-cuda--sm_50`, instead of `nvptx64-nvidia-cuda-sm_50-`. In addition never skip standardization so that triples like `nvptx64-nvidia-cuda-`, are also properly standardized to `nvptx64-nvidia-cuda--`.
asudarsa
approved these changes
Jul 19, 2023
Contributor
asudarsa
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix.
Contributor
|
Hi @npmiller Thanks for the fix again. can you please sync your PR to get latest changes? The fix to the build issue was checked in yesterday and so the testing after the sync should be useful. |
Contributor
|
Can you please take a look and merge if it looks ok to you? Thanks |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
This patch fixes small issues after intel#9631 When standardizing the triples the format should be: ``` <arch><sub>-<vendor>-<sys>-<env> ``` * https://clang.llvm.org/docs/CrossCompilation.html#target-triple And then we add our offload arch afterwards, so the final triples should look something like: `nvptx64-nvidia-cuda--sm_50`, instead of `nvptx64-nvidia-cuda-sm_50-`. In addition never skip standardization so that triples like `nvptx64-nvidia-cuda-`, are also properly standardized to `nvptx64-nvidia-cuda--`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes small issues after #9631
When standardizing the triples the format should be:
And then we add our offload arch afterwards, so the final triples should look something like:
nvptx64-nvidia-cuda--sm_50, instead ofnvptx64-nvidia-cuda-sm_50-.In addition never skip standardization so that triples like
nvptx64-nvidia-cuda-, are also properly standardized tonvptx64-nvidia-cuda--.