[SYCL][UX] Diagnostic for undefined device functions#1026
Merged
bader merged 58 commits intointel:syclfrom Mar 10, 2020
Merged
Conversation
AGindinson
reviewed
Jan 20, 2020
Fznamznon
reviewed
Jan 20, 2020
Fznamznon
reviewed
Jan 20, 2020
Fznamznon
reviewed
Jan 20, 2020
Fznamznon
reviewed
Jan 20, 2020
Fznamznon
reviewed
Jan 20, 2020
Contributor
|
Diagnostic for undefined kernel functions -> Diagnostic for undefined device functions |
erichkeane
reviewed
Jan 20, 2020
|
As long as we can circumvent the check with SYCL_EXTERNAL for functions we want to deal with in the FPGA device compiler, I think we are good from the FPGA side. |
Contributor
Author
@d86thoffner, as far as I understand both approaches from the description of this PR are OK for you, aren't they? |
|
Yes, as I tried to say, looks to me like this is not triggered for functions marked SYCL_EXTERNAL. |
erichkeane
reviewed
Jan 21, 2020
Contributor
erichkeane
left a comment
There was a problem hiding this comment.
Clang changes look fine delta @Fznamznon format comments.
Fznamznon
reviewed
Jan 21, 2020
bader
reviewed
Feb 28, 2020
added 2 commits
February 28, 2020 14:53
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
9df6f9d to
cdfee11
Compare
Fznamznon
previously approved these changes
Feb 28, 2020
| } | ||
|
|
||
| Sema::FunctionEmissionStatus Sema::getEmissionStatus(FunctionDecl *FD) { | ||
| // Due to SYCL functions are template we check if they have appropriate |
Contributor
There was a problem hiding this comment.
Doesn't seem to be a full sentence. Word missing?
Contributor
Author
There was a problem hiding this comment.
Can't see what is missing in "Due to SYCL functions are template we check if they have appropriate attribute prior to checking if it is a template"
Fznamznon
previously approved these changes
Mar 10, 2020
bader
reviewed
Mar 10, 2020
added 2 commits
March 10, 2020 14:01
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
bader
reviewed
Mar 10, 2020
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com> Co-Authored-By: Alexey Bader <alexey.bader@intel.com>
bader
approved these changes
Mar 10, 2020
Fznamznon
approved these changes
Mar 10, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 12, 2020
…e_api_test * origin/sycl: [SYCL][NFC] Fix static code analysis concerns (intel#1283) [SYCL] Fix the test/basic_tests/buffer/subbuffer.cpp (intel#1277) [SYCL][CUDA] Implement the program kernel names query (intel#1248) [SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time (intel#1261) [SYCL][UX] Diagnostic for undefined device functions (intel#1026) [SYCL] Reverse reqd_work_group_size attribute (intel#1234) [SYCL] Rename project to oneAPI DPC++ Compiler (intel#1249) [SYCL][XPTI] Instrumentation of SYCL runtime with XPTI (intel#1129)
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 13, 2020
…st_commit * otcshare/sycl: (469 commits) [SYCL] Implement thread-local storage restriction (intel#1281) [Driver][SYCL][FPGA] Adjust the output location for the project report (intel#1278) [SYCL][NFC] Fix static code analysis concerns (intel#1283) [SYCL] Fix the test/basic_tests/buffer/subbuffer.cpp (intel#1277) [SYCL][CUDA] Implement the program kernel names query (intel#1248) [SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time (intel#1261) [SYCL][UX] Diagnostic for undefined device functions (intel#1026) [SYCL] Reverse reqd_work_group_size attribute (intel#1234) [SYCL] Rename project to oneAPI DPC++ Compiler (intel#1249) [SYCL][XPTI] Instrumentation of SYCL runtime with XPTI (intel#1129) [SYCL] Add buffer dimensions restriction (intel#1147) [SYCL][NFC] Update copyright header in handler files (intel#1271) [SYCL][NFC] Format the code with clang-format [SYCL][Test] Fix SYCL library location path for LIT tests (intel#1228) [SYCL][NFC] Fix doxygen warnings (intel#1270) [SYCL][CUDA] Add the CUDA backend to the deploy-sycl-toolchain target (intel#1268) [SYCL][NFC] Fix a misleading comment regarding the SYCL flow (intel#1266) Change capability for SpecId decoration README.md: Mention retrieving llvm archive signatures travis: Restore macOS builds ...
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 15, 2020
…_accessor_refactor * origin/sycl: (454 commits) [SYCL][NFC] Fix static code analysis concerns (intel#1283) [SYCL] Fix the test/basic_tests/buffer/subbuffer.cpp (intel#1277) [SYCL][CUDA] Implement the program kernel names query (intel#1248) [SYCL] Honor the LLVM_LIBDIR_SUFFIX variable at installation time (intel#1261) [SYCL][UX] Diagnostic for undefined device functions (intel#1026) [SYCL] Reverse reqd_work_group_size attribute (intel#1234) [SYCL] Rename project to oneAPI DPC++ Compiler (intel#1249) [SYCL][XPTI] Instrumentation of SYCL runtime with XPTI (intel#1129) [SYCL] Add buffer dimensions restriction (intel#1147) [SYCL][NFC] Update copyright header in handler files (intel#1271) [SYCL][NFC] Format the code with clang-format [SYCL][Test] Fix SYCL library location path for LIT tests (intel#1228) [SYCL][NFC] Fix doxygen warnings (intel#1270) [SYCL][CUDA] Add the CUDA backend to the deploy-sycl-toolchain target (intel#1268) Change capability for SpecId decoration README.md: Mention retrieving llvm archive signatures travis: Restore macOS builds Fix DebugInfo creation after LLVM change 7a42bab Add more missing mixes Add missing fixes ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brand new diagnostic introduced: "call an undefined function w/o SYCL_EXTERNAL attribute"
The diagnostic is displayed for functions definitions of which are not available when its declaration is not marked with SYCL_EXTERNAL attribute if and only if the method is found in callgraph (i.e. it will be called during runtime).
For this purpose there is a hack: attribute
__SYCL__HAS_DEFINITION__is used to suppress the diagnostic for__spirv_*and__spirv_ocl_*functions.Standard library functions implementation is either of:
The patch does not provide a facility for the second approach. Anyway, the approach should be smth similar to already used in devicelib.