Handle corner in dynamic index with insufficient valid search results #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sufficient results due to deleted vectors and sparse graph connectivity
dian-lun-lin
reviewed
Aug 8, 2025
dian-lun-lin
approved these changes
Aug 8, 2025
ahuber21
pushed a commit
that referenced
this pull request
Aug 12, 2025
…#164) This PR addresses a rare scenario in dynamic indexes where the search buffer may not be populated with enough results. This typically occurs when a large number of vectors have been deleted, resulting in a sparsely connected graph. To ensure robustness, the buffer is now supplemented with additional results when needed. This is a corner case and is not expected to occur frequently, but handling it improves stability and consistency in edge conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a rare scenario in dynamic indexes where the search buffer may not be populated with enough results. This typically occurs when a large number of vectors have been deleted, resulting in a sparsely connected graph. To ensure robustness, the buffer is now supplemented with additional results when needed.
This is a corner case and is not expected to occur frequently, but handling it improves stability and consistency in edge conditions.