Skip to content

Add require_linear_history on github_branch_protection resource#887

Merged
jcudit merged 3 commits intointegrations:mainfrom
charlie-collard:add_require_linear_history
Sep 22, 2021
Merged

Add require_linear_history on github_branch_protection resource#887
jcudit merged 3 commits intointegrations:mainfrom
charlie-collard:add_require_linear_history

Conversation

@charlie-collard
Copy link
Contributor

@charlie-collard charlie-collard commented Aug 19, 2021 •
edited
Loading

Fixes #305

Tested to work locally

majormoses
majormoses approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dududko
Copy link

dududko commented Aug 31, 2021

@majormoses could you please merge this PR into master ?

@jcudit jcudit added this to the v4.15.0 milestone Aug 31, 2021
@jcudit
Copy link
Contributor

jcudit commented Aug 31, 2021

❤️ excited to see this one ship. Will need to get this tested but aim to batch this into the next release.

Thanks for the contribution and patience so far!

jcudit
jcudit reviewed Sep 10, 2021
View reviewed changes
jcudit
jcudit approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here to merge once the docs get fixed.

@jcudit jcudit merged commit 6d22c86 into integrations:main Sep 22, 2021
@dav-tb
Copy link

dav-tb commented Oct 13, 2021

Hmmm. Trying to set require_linear_history to true here. No failure from Terraform's planning and applying stages but the setting doesn't get through. On subsequent plan, it sees it as still something to change.

Is there any other setting that may cause it to be ignored?

@schmurfy
Copy link

schmurfy commented Oct 14, 2021

I got exactly the same issue, the plan says it is going to change its value but nothing gets done.
I tried running the plan again with the checkbox checked and unchecked, in both case the value on github was left unchanged after the apply.

@leosunmo leosunmo mentioned this pull request Oct 18, 2021
Closed
@leosunmo
Copy link

leosunmo commented Oct 18, 2021

Same issue here @schmurfy and @Crono1981 . Created an issue for it. Please add any details you have to the issue!

@robzr
Copy link

robzr commented Nov 13, 2021

This does not work - there is an issue raised here for it: #952

@ehrenkret
Copy link

ehrenkret commented Dec 1, 2021

Looks like this reads the linear history flag but doesn't write it. Opened #994 to write it.

kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@charlie-collard
Add require_linear_history on github_branch_protection resource (i…
9a46a6e 
…ntegrations#887)

* Add `require_linear_history` on `github_branch_protection` resource

* Run gofmt

* Move documentation to correct file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@majormoses majormoses majormoses approved these changes

@jcudit jcudit jcudit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.15.0

Development

Successfully merging this pull request may close these issues.

Feature Request > New branch protection features support

9 participants

@charlie-collard @dududko @jcudit @dav-tb @schmurfy @leosunmo @robzr @ehrenkret @majormoses