Add in github_actions_organization_secret#584
Add in github_actions_organization_secret#584jcudit merged 1 commit intointegrations:masterfrom jacobfoard:gh-org-secrets
github_actions_organization_secret#584Conversation
|
🎉 looking good on a quick glance. Can we get a new file added under the website directory that documents this new resource? I believe there would also be a change to add the new documentation to the side navigation area. I can link an example when at my keyboard. Aiming to come back with a more thorough review as well. Thanks for kicking this one off @jacobfoard ! |
|
I added in handling a couple edge cases I hadn't previously tested, added/updated docs, and needed to add in the |
|
@jacobfoard gave this another read and caught a typo. |
|
@jcudit Done, and commits squashed as well. |
github_actions_orginization_secretgithub_actions_organization_secret
jcudit
left a comment
There was a problem hiding this comment.
Spotted a few more fixes to make 😄 .
jcudit
left a comment
There was a problem hiding this comment.
Very close 🎉 . Take a look at the test fixes and commit if all is 👌 . Will look to release this in the upcoming week.
Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> fixing github_actions_secret created/updated timestamp Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> docs, adding repo_id attribute for repository Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> s/orginization/organization/ Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> rename file, add in require param to tests Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> Fixing test copy pasta Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com>
|
Alright, I believe the last of the copy pasta has been cleaned up. Thanks for your patience, I'll make sure my next contribution isn't as rushed 😅. |
|
❤️ this contribution. Looks like a popular one from the community's view, so 🙇 for making everyone's life a bit easier. Aiming to release this week. |
Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> fixing github_actions_secret created/updated timestamp Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> docs, adding repo_id attribute for repository Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> s/orginization/organization/ Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> rename file, add in require param to tests Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com> Fixing test copy pasta Signed-off-by: Jacob Foard <jacob.foard@greenparksports.com>
This fixes #468.
This almost exclusively follows the same patterns as
github_actions_secret, but happy to address any feedback!I also fixed the
updated_atandcreated_atfields ongithub_actions_secretfrom the string"default"to being a proper timestamp.