repo webhook url is sensitive#540
Merged
jcudit merged 2 commits intointegrations:masterfrom Nov 5, 2020
Merged
Conversation
majormoses
approved these changes
Oct 11, 2020
Contributor
majormoses
left a comment
There was a problem hiding this comment.
LGTM
It might be good to update the docs to indicate why this is sensitive as that may not be obvious if you are not thinking about embedding credentials into the URL and are relying on other mechanisms such as verifying the signature of the payloads from github. I am not disagreeing on the validity of using auth to establish an additional entry point into say an auth proxy, just that we should document it's rationale.
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
* repo webhook url is sensitive * document the reason for marking url sensitive Co-authored-by: kzw <kzw@noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This marks URL of repo webhook as sensitive. A use case is for atlantis server where URL contains basic auth credentials.