Skip to content

resource/repository_collaborator: revert response handling introduced in #424#525

Merged
jcudit merged 1 commit intomasterfrom
b-repo-collaborator-regression
Jul 31, 2020
Merged

resource/repository_collaborator: revert response handling introduced in #424#525
jcudit merged 1 commit intomasterfrom
b-repo-collaborator-regression

Conversation

@anGie44
Copy link
Copy Markdown
Collaborator

@anGie44 anGie44 commented Jul 31, 2020

Closes #469

Notes

  • Previously, handling was added to validate the response returned from the Github API when an attempt was made to add a collaborator but this proved to be problematic and breaking

Output of acceptance tests:

--- PASS: TestAccGithubRepositoryCollaborator_basic_personal (13.40s)
--- PASS: TestAccGithubRepositoryCollaborator_basic (26.76s)
--- PASS: TestAccGithubRepositoryCollaborator_caseInsensitive_personal (27.61s)
--- PASS: TestAccGithubRepositoryCollaborator_caseInsensitive (23.75s)

@ghost ghost added the size/XS label Jul 31, 2020
@jcudit jcudit merged commit ea27b4a into master Jul 31, 2020
@anGie44 anGie44 deleted the b-repo-collaborator-regression branch August 14, 2020 14:48
@anGie44 anGie44 added this to the v3.0.0 milestone Aug 14, 2020
@anGie44 anGie44 mentioned this pull request Aug 14, 2020
Closed
@preston-hf
Copy link
Copy Markdown

preston-hf commented Aug 27, 2020

Would you consider backporting this to the 2.x series? It seems like 3.x will take a little while longer and this is a small change. It would help me out as we are getting this exact error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jcudit jcudit jcudit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

github_repository_collaborator broken since v2.8.0

3 participants

@anGie44 @preston-hf @jcudit