Skip to content

upgrade provider to go-github v31.0.0 to support new API methods #424

Merged
anGie44 merged 5 commits intomasterfrom
ap_go_github_upgrade_v31
May 5, 2020
Merged

upgrade provider to go-github v31.0.0 to support new API methods #424
anGie44 merged 5 commits intomasterfrom
ap_go_github_upgrade_v31

Conversation

@anGie44
Copy link
Copy Markdown
Collaborator

@anGie44 anGie44 commented Apr 10, 2020 •
edited
Loading

This release of go-github will enable provider support of IdP groups for teams ; data and resource to be added in #400

Changes include:

  • import go-github references modified from v29 -> v31
  • #GetTeamMembership -> #GetTeamMembershipByID
  • #ListTeamMembers -> #ListTeamMembersByID

@ghost ghost added the size/XXL label Apr 10, 2020
@anGie44
Copy link
Copy Markdown
Collaborator Author

anGie44 commented Apr 10, 2020

Only Acceptance test failure I see atm is for the ssh key referenced (seems expected):

--- FAIL: TestAccGithubUserSshKey_basic (0.35s)
    testing.go:654: Step 0 error: errors during apply:
        
        Error: POST https://api.github.com/user/keys: 422 Validation Failed [{Resource:PublicKey Field:key Code:custom Message:key is already in use}]
        
          on /tmp/tf-test215372987/main.tf line 2:
          (source code not available)
        
        
FAIL
FAIL	github.com/terraform-providers/terraform-provider-github/github	0.365s

@anGie44 anGie44 requested a review from jcudit April 10, 2020 17:37
@anGie44 anGie44 mentioned this pull request Apr 10, 2020
Merged
@gesellix gesellix mentioned this pull request Apr 11, 2020
Closed
@anGie44
Merge branch 'master' into ap_go_github_upgrade_v31
41376f1 
# Conflicts:
#	github/data_source_github_team.go
#	github/resource_github_team_membership.go
#	github/resource_github_team_membership_test.go
#	go.mod
#	vendor/modules.txt
@anGie44
Copy link
Copy Markdown
Collaborator Author

anGie44 commented Apr 16, 2020

Additional test failures relating to missing GITHUB_BASE_URL env var I believe:

--- FAIL: TestAccGithubRepository_defaultBranch (5.39s)
panic: Error creating github client: Get /v3/orgs/terraformtesting: unsupported protocol scheme "" [recovered]
--- FAIL: TestAccProvider_insecure (0.09s)
    testing.go:654: Step 1 error: errors during refresh:
        
        Error: GET https://localhost:56676/v3/orgs/terraformtesting: 404  []

@anGie44 anGie44 added this to the v2.8.0 milestone Apr 21, 2020
@patrickmarabeas patrickmarabeas mentioned this pull request May 1, 2020
Merged
@anGie44
Copy link
Copy Markdown
Collaborator Author

anGie44 commented May 5, 2020 •
edited
Loading

Acceptance tests, after merge with master, are passing w/the following known exceptions (including https://github.com/terraform-providers/terraform-provider-github/issues/431):

--- FAIL: TestAccGithubUserSshKey_basic (24.95s) -- key is already in use
--- FAIL: TestAccGithubTeam_slug (102.98s) -- ImportStateVerify attributes (etag) not equivalent
--- FAIL: TestAccGithubTeam_basic (162.71s) -- ImportStateVerify attributes (etag) not equivalent
--- FAIL: TestAccGithubTeam_hierarchical (168.66s) -- ImportStateVerify attributes (etag) not equivalent
--- FAIL: TestAccGithubRepositoryDeployKey_basic (71.41s) -- key is already in use

@anGie44 anGie44 merged commit 2b32916 into master May 5, 2020
@anGie44 anGie44 deleted the ap_go_github_upgrade_v31 branch May 5, 2020 01:54
anGie44 added a commit that referenced this pull request May 5, 2020
@anGie44
Update CHANGELOG for #424
bab3294
@jcudit jcudit mentioned this pull request May 8, 2020
Closed
anGie44 added a commit that referenced this pull request Jul 31, 2020
@anGie44
revert response handling introduced in #424
205d7c3
jcudit pushed a commit that referenced this pull request Jul 31, 2020
@anGie44
revert response handling introduced in #424
ea27b4a
@anGie44 anGie44 mentioned this pull request Aug 14, 2020
Closed
jcudit pushed a commit that referenced this pull request Sep 2, 2020
@anGie44
revert response handling introduced in #424
454a7cc
jcudit pushed a commit that referenced this pull request Sep 4, 2020
@anGie44
revert response handling introduced in #424
100d7ca
jcudit pushed a commit that referenced this pull request Sep 5, 2020
Revert "revert response handling introduced in #424"
11ba791 
This reverts commit 100d7ca.
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@anGie44
Merge pull request integrations#424 from terraform-providers/ap_go_gi…
36a4ecc 
…thub_upgrade_v31

upgrade provider to go-github v31.0.0 to support new API methods
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@anGie44
Update CHANGELOG for integrations#424
0f08a6b
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@anGie44
revert response handling introduced in integrations#424
eb9492d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcudit jcudit Awaiting requested review from jcudit

Assignees

No one assigned

Labels

size/XXL

Projects

None yet

Milestone

v2.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@anGie44 @analytically