Skip to content

Add support for importing organization-level webhooks#487

Merged
jcudit merged 1 commit intointegrations:masterfrom
mhuxtable:feature/org_webhook_import_support
Nov 5, 2020
Merged

Add support for importing organization-level webhooks#487
jcudit merged 1 commit intointegrations:masterfrom
mhuxtable:feature/org_webhook_import_support

Conversation

@mhuxtable
Copy link
Copy Markdown
Contributor

@mhuxtable mhuxtable commented Jun 10, 2020

This introduces support for importing webhooks from GitHub organization
objects. This was already supported for repository-level webhooks, and
the implementation is similar with the exception of some changes to ID
handling.

@ghost ghost added the size/XS label Jun 10, 2020
@MPV
Copy link
Copy Markdown

MPV commented Jun 17, 2020

I created #493 and was happy to discover this PR just now.

@mhuxtable Looks like there's a conflict in github/resource_github_organization_webhook_test.go — would you like to take a look? 😊

@mhuxtable mhuxtable force-pushed the feature/org_webhook_import_support branch from 28cbe56 to e4084f8 Compare June 17, 2020 21:40
@ghost ghost added size/S Type: Documentation Improvements or additions to documentation and removed size/XS labels Jun 17, 2020
@mhuxtable
Copy link
Copy Markdown
Contributor Author

mhuxtable commented Jun 17, 2020

I created #493 and was happy to discover this PR just now.

@mhuxtable Looks like there's a conflict in github/resource_github_organization_webhook_test.go — would you like to take a look? 😊

@MPV That's done, and your comment prompted me to complete an outstanding TODO by updating the docs – thanks.

If you wanted to use this locally before it's merged, you should be able to build it and use it provided it's on your path. I give my locally built providers a unique version suffix e.g. 2.8.1-org, which I specify in the version property of the provider to ensure the expected instance is used.

I've used this just recently to import org webhooks to an existing GitHub organization. I hope you can make use of it too!

@anGie44 anGie44 linked an issue Jun 18, 2020 that may be closed by this pull request
Support import of github_organization_webhook #493
Closed
@MPV
Copy link
Copy Markdown

MPV commented Oct 21, 2020

Seems this PR isn't mergable now due to it now has conflicts?

@jcudit jcudit force-pushed the feature/org_webhook_import_support branch from e4084f8 to 2e0a685 Compare November 5, 2020 12:18
@jcudit
Copy link
Copy Markdown
Contributor

jcudit commented Nov 5, 2020

🤔 not sure why the acceptance tests are having such a hard time. It may have something to do with the age of this PR 😊 .

I've copied the commits into another branch and have observed tests pass for individual accounts. Happy to merge despite the failing checks and can follow up with corrections to organization account testing in a separate PR. Thanks to all who've waited / contributed 🙇 .

@jcudit jcudit added this to the v4.0.0 milestone Nov 5, 2020
@jcudit jcudit merged commit 900aa92 into integrations:master Nov 5, 2020
@jcudit jcudit mentioned this pull request Nov 5, 2020
Merged
@mhuxtable mhuxtable deleted the feature/org_webhook_import_support branch November 6, 2020 00:28
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@mhuxtable
Add support for importing organization-level webhooks (integrations#487)
d25ebd5 
Co-authored-by: Jeremy Udit <jcudit@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jcudit jcudit jcudit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S Type: Documentation Improvements or additions to documentation

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Support import of github_organization_webhook

3 participants

@mhuxtable @MPV @jcudit