Handle pagination when listing commits in github_repository_file#366
Merged
jcudit merged 1 commit intointegrations:masterfrom Feb 27, 2020
shoekstra:repository_file__add_list_commit_pagination
Merged
Handle pagination when listing commits in github_repository_file#366jcudit merged 1 commit intointegrations:masterfrom shoekstra:repository_file__add_list_commit_pagination
jcudit merged 1 commit intointegrations:masterfrom
shoekstra:repository_file__add_list_commit_pagination
Conversation
Original use-case/tests did not cover pagination when looking up the commit info for a while, this commit adds it. Signed-off-by: Stephen Hoekstra <shoekstra@schubergphilis.com>
jcudit
approved these changes
Feb 27, 2020
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…dd_list_commit_pagination Handle pagination when listing commits in github_repository_file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @jcudit, @kpfleming,
When using
github_repository_file, the resource attempts to lookup the file's commit info which involves listing all commits in a branch and looping backwards until it finds a commit containing the file.Alas I didn't cover pagination when listing these commits for a branch which will cause a problem when the file's commit was too far in the past, users would see something like this:
This PR fixes this by adding missing support for pagination - couldn't write a test for this but have fixed the issue we found in one of our repos.