Skip to content

fix: Correct forking and vulnerability alert logic#3127

Merged
stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell:repo-vulnrability-alerts
Jan 28, 2026
Merged

fix: Correct forking and vulnerability alert logic#3127
stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell:repo-vulnrability-alerts

Conversation

@stevehipwell
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell commented Jan 27, 2026 •
edited
Loading

Resolves #2988
Resolves #3111

Before the change?

  • Setting allow_forking = false on github_repository resulted in incorrect behaviour
  • The vulnerability_alerts attribute of github_repository couldn't be left unset to support default behaviour
  • Missing tests for github_repository allow forking and vulnerability alerts
  • Tests from github_organization_role_users data source were broken

After the change?

  • Setting allow_forking = false on github_repository works as expected
  • The vulnerability_alerts attribute of github_repository works correctly when unset
  • Tests for github_repository allow forking and vulnerability alerts added
  • Tests from github_organization_role_users data source fixed

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell stevehipwell added this to the v6.11.0 Release milestone Jan 27, 2026
@stevehipwell stevehipwell self-assigned this Jan 27, 2026
@stevehipwell stevehipwell added the Type: Bug Something isn't working as documented label Jan 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 27, 2026

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@stevehipwell stevehipwell mentioned this pull request Jan 27, 2026
Closed
1 task
deiga
deiga approved these changes Jan 27, 2026
View reviewed changes
@stevehipwell stevehipwell force-pushed the repo-vulnrability-alerts branch from b0d23ac to 389ba14 Compare January 27, 2026 16:26
deiga
deiga reviewed Jan 27, 2026
View reviewed changes
nickfloyd
nickfloyd approved these changes Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@stevehipwell
fix: Correct forking and vulnerability alert logic
058a2fc 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell force-pushed the repo-vulnrability-alerts branch from 389ba14 to 058a2fc Compare January 28, 2026 21:44
@stevehipwell stevehipwell enabled auto-merge (squash) January 28, 2026 21:44
@stevehipwell stevehipwell merged commit fe26d26 into integrations:main Jan 28, 2026
7 checks passed
@stevehipwell stevehipwell deleted the repo-vulnrability-alerts branch January 28, 2026 22:00
@stevehipwell stevehipwell mentioned this pull request Jan 28, 2026
Closed
5 tasks
deiga pushed a commit to F-Secure-web/terraform-provider-github that referenced this pull request Jan 29, 2026
@stevehipwell @deiga
fix: Correct forking and vulnerability alert logic (integrations#3127)
eb64f11 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
This was referenced Jan 30, 2026
Merged
Closed
@stevehipwell stevehipwell mentioned this pull request Feb 6, 2026
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

+1 more reviewer

@deiga deiga deiga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stevehipwell stevehipwell

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Milestone

v6.11.0 Release

Development

Successfully merging this pull request may close these issues.

[BUG]: cannot use ignore_vulnerability_alerts_during_read for terraform import [BUG]: creation of github_repository fails from v6.7.0 onwards

3 participants

@stevehipwell @deiga @nickfloyd