[BUG] github_organization_role Ensure role_id is set after Create#3011
Conversation
Since it's a computed value, it should be set in Create and Read Signed-off-by: Timo Sand <timo.sand@f-secure.com>
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Yeah, I see those docs, but running the tests on GHEC gives me a 422 Validation error if I'm passing in When running a manual curl with {
"message": "Invalid request.\n\nInvalid property /base_role: `none` is not a possible value. Must be one of the following: read, triage, write, maintain, admin.",
"documentation_url": "https://docs.github.com/rest/orgs/organization-roles#create-a-custom-organization-role",
"status": "422"
} |
Signed-off-by: Timo Sand <timo.sand@f-secure.com>
Resolves #3009
Resolves #3004
Before the change?
role_idwouldn't not be set duringapply, only on nextplan, thus rendering the resource unusable for referencesAfter the change?
role_idis set in Create allowing it to be used in referencesPull request checklist
Schema migrations have been created if needed (example)Does this introduce a breaking change?
Please see our docs on breaking changes to help!