fix: Fix org roles implementation#2968
Merged
nickfloyd merged 1 commit intointegrations:mainfrom Dec 5, 2025
Merged
Conversation
4dd960f to
43c7339
Compare
deiga
reviewed
Dec 4, 2025
Collaborator
deiga
left a comment
There was a problem hiding this comment.
Would you be able to add a test case which reproduces the error from the reported issue?
Collaborator
Author
@deiga there is already a test for the org role error, that worked prior to the API changing. The other error is a distributed system error that can't easily be tested, as it'd be proving a negative; but we do have tests. We've seen the same problem in other areas in the API and need to get rid of the re-read pattern. Interestingly the resource failing here is having to use a list for get pattern as the get API was a later addition and needs v68. Also interesting is that at least one report is from GHES. |
43c7339 to
c8e5b2b
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
c8e5b2b to
61057bb
Compare
nickfloyd
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2805
Resolves #2960
This PR improves on the code in #2487.
Before the change?
github_organization_roledidn't correctly support org only permissionsAfter the change?
github_organization_rolecan support org only permissions or no permissionsPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!