fix: change fork to TypeString and add conditional ForceNew#2959
Merged
diofeher merged 5 commits intointegrations:mainfrom Dec 3, 2025
Merged
fix: change fork to TypeString and add conditional ForceNew#2959diofeher merged 5 commits intointegrations:mainfrom
fork to TypeString and add conditional ForceNew#2959diofeher merged 5 commits intointegrations:mainfrom
Conversation
resource_github_repository
c5da0c5 to
62333fb
Compare
Collaborator
Author
|
I wasn't able to find a way to automate the test as I was doing it manually. It would be helpful to have another round of testing, though. |
resource_github_repositoryfork in resource_github_repository
fork in resource_github_repositoryfork in resource_github_repository
2067b0c to
dc71e81
Compare
dc71e81 to
c8478e8
Compare
fork in resource_github_repositoryfork to TypeString
Collaborator
|
I think we might need to do the same to the |
Signed-off-by: Diogenes Fernandes <diofeher@gmail.com>
Collaborator
Author
|
@deiga Thanks for the catch! I previously added to them but removed them in later iterations. So just using the |
Collaborator
Author
|
I tested migrating from the existing field "TypeBool" to "TypeString," and it also worked well. |
nickfloyd
reviewed
Dec 3, 2025
Member
nickfloyd
left a comment
There was a problem hiding this comment.
It looks like we still need ForceNewIfChange for both source_owner and source_repo.
Signed-off-by: Diogenes Fernandes <diofeher@gmail.com>
deiga
reviewed
Dec 3, 2025
Signed-off-by: Diogenes Fernandes <diofeher@gmail.com>
fork to TypeStringfork to TypeString and add conditional ForceNew
Collaborator
Author
|
Thanks for the reviews @deiga and @nickfloyd |
diofeher
commented
Dec 3, 2025
| return oldValStr != "" && oldValStr != newValStr | ||
| } | ||
|
|
||
| func customDiffFunction(_ context.Context, diff *schema.ResourceDiff, v any) error { |
Collaborator
Author
There was a problem hiding this comment.
I'm moving this function closer to where it's used so it's easier to read and navigate.
nickfloyd
approved these changes
Dec 3, 2025
deiga
approved these changes
Dec 3, 2025
1 task
AlanCitrix
pushed a commit
to AlanCitrix/terraform-provider-github
that referenced
this pull request
Dec 10, 2025
…grations#2959) * fix: change "fork" to TypeString * lint + computed on source_owner and source_repo Signed-off-by: Diogenes Fernandes <diofeher@gmail.com> * adding automated test Signed-off-by: Diogenes Fernandes <diofeher@gmail.com> * source_repo and source_owner logic added Signed-off-by: Diogenes Fernandes <diofeher@gmail.com> * lint Signed-off-by: Diogenes Fernandes <diofeher@gmail.com> --------- Signed-off-by: Diogenes Fernandes <diofeher@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2954
Before the change?
forkfield. Now that we're supporting that, any resource that adds the attribute triggers recreation, even if the attribute is the same as the one returned by the API.After the change?
Computedto the field, so the resource has access to the value to calculate if it needs to recreate the resource. By using that infork, the other two attributes are filled in.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!