Skip to content

feat(actions_permissions): sha_pinning_required #2870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sheeeng wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(actions_permissions): sha_pinning_required #2870

sheeeng wants to merge 2 commits into from
+36 −4

Conversation

@sheeeng
Copy link

@sheeeng sheeeng commented Nov 6, 2025 •
edited
Loading

Wait until google/go-github#3807 is being included in the next release.

Resolves #2869.

Before the change?

  • The sha_pinning_required option for actions permissions is not supported.

After the change?

  • The sha_pinning_required option actions permissions is supported.

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@sheeeng sheeeng mentioned this pull request Nov 8, 2025
Merged
@sheeeng sheeeng force-pushed the feat/actions_permissions_sha_pinning_required branch from 6289202 to 49ad201 Compare November 8, 2025 22:31
@sheeeng sheeeng marked this pull request as ready for review November 8, 2025 22:32
@github-actions github-actions bot added the Type: Feature New feature or request label Nov 10, 2025
nickfloyd
nickfloyd requested changes Nov 10, 2025
View reviewed changes
@nickfloyd nickfloyd moved this from Backlog to BLOCKED in Terraform Provider Nov 12, 2025
@nickfloyd nickfloyd modified the milestone: v7.0.0 Release Nov 20, 2025
@nickfloyd nickfloyd moved this from BLOCKED to In Progress in Terraform Provider Nov 20, 2025
@sheeeng sheeeng force-pushed the feat/actions_permissions_sha_pinning_required branch from b88390d to 6e23078 Compare December 1, 2025 09:46
@sheeeng sheeeng requested a review from nickfloyd December 1, 2025 09:48
@nickfloyd nickfloyd modified the milestones: v7.0.0 Release, v7 Next Dec 1, 2025
@sheeeng
Copy link
Author

sheeeng commented Dec 2, 2025

I ran go get github.com/google/go-github/v79@latest and go mod tidy && go mod vendor, but make build still failing. Any tips to fix this build and/or lint errors? @nickfloyd

@deiga
Copy link
Contributor

deiga commented Dec 2, 2025

@sheeeng The provider doesn't support go-github v79 yet. We're on v67 and getting to v79 in our v7 release.

You could try rebase on #2898, but that might not build currently either

@sheeeng sheeeng marked this pull request as draft December 3, 2025 09:23
@sheeeng
Copy link
Author

sheeeng commented Dec 3, 2025

@nickfloyd, thanks! I guess I will only update this pull request once the provider supports go-github v79.. 🙇

@deiga
Copy link
Contributor

deiga commented Jan 7, 2026

@sheeeng We now have go-github v81! You should be good to finalize this now :)

@sheeeng sheeeng force-pushed the feat/actions_permissions_sha_pinning_required branch 2 times, most recently from e98cc10 to 1bbc69f Compare January 9, 2026 11:00
@sheeeng sheeeng marked this pull request as ready for review January 9, 2026 11:01
deiga
deiga suggested changes Jan 9, 2026
View reviewed changes
@sheeeng sheeeng requested a review from deiga January 9, 2026 18:06
deiga
deiga suggested changes Jan 9, 2026
View reviewed changes
@sheeeng sheeeng marked this pull request as draft January 12, 2026 11:38
@sheeeng sheeeng force-pushed the feat/actions_permissions_sha_pinning_required branch from 9e57d44 to 4850248 Compare January 12, 2026 11:49
@sheeeng sheeeng force-pushed the feat/actions_permissions_sha_pinning_required branch 2 times, most recently from c1b528b to d2261b8 Compare January 12, 2026 12:20
@sheeeng sheeeng marked this pull request as ready for review January 12, 2026 12:32
@sheeeng sheeeng requested a review from deiga January 12, 2026 12:32
@sheeeng
feat(actions_permissions): sha_pinning_required
bc214db 
Fix integrations#2869.

Signed-off-by: Leonard Sheng Sheng Lee <leonard.sheng.sheng.lee@gmail.com>
Signed-off-by: Leonard Sheng Sheng Lee <305414+sheeeng@users.noreply.github.com>
@sheeeng sheeeng force-pushed the feat/actions_permissions_sha_pinning_required branch from d2261b8 to bc214db Compare January 15, 2026 08:54
stevehipwell
stevehipwell requested changes Jan 15, 2026
View reviewed changes
Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheeeng I think you need to make sha_pinning_required computed as well as optional as if the user doesn't set it we're looking it up.

@stevehipwell
Copy link
Collaborator

stevehipwell commented Jan 16, 2026

@sheeeng we're looking to release the v6.10.0 milestone today, if you don't have time to update the PR I'd be happy to finish it off for you so it makes the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevehipwell stevehipwell stevehipwell requested changes

@nickfloyd nickfloyd Awaiting requested review from nickfloyd

+1 more reviewer

@deiga deiga deiga approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Type: Feature New feature or request

Projects

Terraform Provider
Status: In Progress

Milestone

v6.11.0 Release

Development

Successfully merging this pull request may close these issues.

[FEAT]: Support sha_pinning_required for Actions permissions

4 participants

@sheeeng @deiga @stevehipwell @nickfloyd