fix: Refactored github_repository_collaborators for team id#2420
Merged
kfcampbell merged 1 commit intointegrations:mainfrom Oct 11, 2024
Merged
fix: Refactored github_repository_collaborators for team id#2420kfcampbell merged 1 commit intointegrations:mainfrom
kfcampbell merged 1 commit intointegrations:mainfrom
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
kfcampbell
approved these changes
Oct 11, 2024
Contributor
kfcampbell
left a comment
There was a problem hiding this comment.
Confirming the adjusted integration tests look good for me locally. Thank you for your effort and attention to testing, @stevehipwell!
1 task
1 task
matijs
added a commit
to nl-design-system/terraform
that referenced
this pull request
Jan 22, 2025
For `github_repository_collaborators` `team` blocks, use the team id instead of the team slug. [This change][1] in the GitHub integration caused a lot of noise that is now fixed. [1]: integrations/terraform-provider-github#2420
matijs
added a commit
to nl-design-system/terraform
that referenced
this pull request
Jan 22, 2025
For `github_repository_collaborators` `team` blocks, use the team id instead of the team slug. [This change][1] in the GitHub integration caused a lot of noise that is now fixed. [1]: integrations/terraform-provider-github#2420
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2414
Resolves #2393
Resolves #2149
Before the change?
github_repository_collaboratorschurned to setteam_idto the team sluggithub_repository_collaboratorsmade an API call for each team when reading the stategithub_repository_collaboratorshad logic issues in the order of operationsAfter the change?
github_repository_collaboratorskeepsteam_idas the user input itgithub_repository_collaboratorsonly makes an API for teams identified by their sluggithub_repository_collaboratorsnow adds and modifies teams before removing existing ones and processes teams before usersPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!