Do not change allow_update_branch/has_downloads on archived repos#1795
Merged
kfcampbell merged 1 commit intointegrations:mainfrom Jul 14, 2023
kristian-lesko:archived-repos
Merged
Do not change allow_update_branch/has_downloads on archived repos#1795kfcampbell merged 1 commit intointegrations:mainfrom kristian-lesko:archived-repos
kfcampbell merged 1 commit intointegrations:mainfrom
kristian-lesko:archived-repos
Conversation
Avoid causing a permanent `plan` diff by attempting to change attributes that can no longer be modified if a repository is archived. Fixes #1793.
jsifuentes
pushed a commit
to jsifuentes/terraform-provider-github
that referenced
this pull request
Jul 17, 2023
…tegrations#1795) Avoid causing a permanent `plan` diff by attempting to change attributes that can no longer be modified if a repository is archived. Fixes integrations#1793.
felixlut
pushed a commit
to felixlut/terraform-provider-github
that referenced
this pull request
Jul 22, 2023
…tegrations#1795) Avoid causing a permanent `plan` diff by attempting to change attributes that can no longer be modified if a repository is archived. Fixes integrations#1793.
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…tegrations#1795) Avoid causing a permanent `plan` diff by attempting to change attributes that can no longer be modified if a repository is archived. Fixes integrations#1793.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid causing a permanent
plandiff by attempting to change attributes that can no longer be modified if a repository is archived.Resolves #1793.
Behavior
Before the change?
The
has_downloadsandallow_update_branchattributes are attempted to be changed on archived repositories, which silently succeeds but doesn't actually change anything (since it's not allowed if a repository is archived). This causes a permanent configuration drift to be reported byterraform planin some cases.After the change?
The
has_downloadsandallow_update_branchattributes are only set on repositories that are not archived.Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance