Skip to content

github_repository: Make non-updatable fields ForceNew#135

Merged
radeksimko merged 1 commit intomasterfrom
b-forcenew-auto-init
Aug 15, 2018
Merged

github_repository: Make non-updatable fields ForceNew#135
radeksimko merged 1 commit intomasterfrom
b-forcenew-auto-init

Conversation

@radeksimko
Copy link
Copy Markdown
Contributor

@radeksimko radeksimko commented Aug 15, 2018

Before patch

TF_ACC=1 go test ./github -v -run=TestAccGithubRepository_autoInitForceNew -timeout 120m
=== RUN   TestAccGithubRepository_autoInitForceNew
--- FAIL: TestAccGithubRepository_autoInitForceNew (3.69s)
	testing.go:518: Step 1 error: Error applying: 1 error(s) occurred:

		* github_branch_protection.repo_name_master: 1 error(s) occurred:

		* github_branch_protection.repo_name_master: PUT https://api.github.com/repos/terraformtesting/tf-acc-test-9t6u4hp8pe/branches/master/protection: 404 Branch not found []
FAIL
FAIL	github.com/terraform-providers/terraform-provider-github/github	3.723s

After patch

TF_ACC=1 go test ./github -v -run=TestAccGithubRepository_ -timeout 120m
=== RUN   TestAccGithubRepository_basic
--- PASS: TestAccGithubRepository_basic (4.00s)
=== RUN   TestAccGithubRepository_archive
--- PASS: TestAccGithubRepository_archive (2.48s)
=== RUN   TestAccGithubRepository_archiveUpdate
--- PASS: TestAccGithubRepository_archiveUpdate (5.34s)
=== RUN   TestAccGithubRepository_importBasic
--- PASS: TestAccGithubRepository_importBasic (2.33s)
=== RUN   TestAccGithubRepository_defaultBranch
--- PASS: TestAccGithubRepository_defaultBranch (5.72s)
=== RUN   TestAccGithubRepository_templates
--- PASS: TestAccGithubRepository_templates (3.22s)
=== RUN   TestAccGithubRepository_topics
--- PASS: TestAccGithubRepository_topics (7.68s)
=== RUN   TestAccGithubRepository_autoInitForceNew
--- PASS: TestAccGithubRepository_autoInitForceNew (6.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-github/github	37.250s

@radeksimko radeksimko added the Type: Bug Something isn't working as documented label Aug 15, 2018
bflad
bflad approved these changes Aug 15, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@radeksimko radeksimko merged commit e139c21 into master Aug 15, 2018
@radeksimko radeksimko deleted the b-forcenew-auto-init branch August 15, 2018 16:44
@gabrielsyapse gabrielsyapse mentioned this pull request Sep 7, 2018
Closed
@majormoses majormoses mentioned this pull request Sep 18, 2018
Closed
jordane added a commit to jordane/terraform-provider-github that referenced this pull request Feb 7, 2019
@jordane
Update github_repository docs
200785d 
After PR integrations#135, auto_init, license_template, and gitignore_template now all
have ForceNew set to true, which means they *will* affect the resource after
initial creation. See also PR integrations#148, integrations#155, integrations#164

Signed-off-by: Jordan Evans <jevans@linuxfoundation.org>
@jordane jordane mentioned this pull request Feb 7, 2019
Merged
@majormoses majormoses mentioned this pull request Jan 5, 2020
Merged
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@radeksimko
Merge pull request integrations#135 from terraform-providers/b-forcen…
0cbecbf 
…ew-auto-init

github_repository: Make non-updatable fields ForceNew
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@jordane
Update github_repository docs
da58517 
After PR integrations#135, auto_init, license_template, and gitignore_template now all
have ForceNew set to true, which means they *will* affect the resource after
initial creation. See also PR integrations#148, integrations#155, integrations#164

Signed-off-by: Jordan Evans <jevans@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bflad bflad bflad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radeksimko @bflad