Suppress plan diff when github_repository changes to archived#1326
Merged
kfcampbell merged 3 commits intointegrations:mainfrom Oct 27, 2022
Merged
Conversation
Closes integrations#1325 GitHub GET /repos/{owner}/{repo} API doesn't return some properties when repository is archived. https://docs.github.com/en/rest/repos/repos#get-a-repository The difference between the results of running the API in the active repository and archived repositories is as follows: - allow_auto_merge - allow_merge_commit - allow_rebase_merge - allow_squash_merge - allow_update_branch (not defined in this code) - delete_branch_on_merge - merge_commit_message - merge_commit_title - squash_merge_commit_message - squash_merge_commit_title - use_squash_pr_title_as_default (not defined in this code) Therefore, I modified not to set these properties when target repository is already archived.
Contributor
|
This looks good, thank you! I'll shoot to get this into a release soon. |
kfcampbell
approved these changes
Oct 27, 2022
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
…ations#1326) Closes integrations#1325 GitHub GET /repos/{owner}/{repo} API doesn't return some properties when repository is archived. https://docs.github.com/en/rest/repos/repos#get-a-repository The difference between the results of running the API in the active repository and archived repositories is as follows: - allow_auto_merge - allow_merge_commit - allow_rebase_merge - allow_squash_merge - allow_update_branch (not defined in this code) - delete_branch_on_merge - merge_commit_message - merge_commit_title - squash_merge_commit_message - squash_merge_commit_title - use_squash_pr_title_as_default (not defined in this code) Therefore, I modified not to set these properties when target repository is already archived. Co-authored-by: Drift Check Updater <gh_actions_drift_check_updater@example.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…ations#1326) Closes integrations#1325 GitHub GET /repos/{owner}/{repo} API doesn't return some properties when repository is archived. https://docs.github.com/en/rest/repos/repos#get-a-repository The difference between the results of running the API in the active repository and archived repositories is as follows: - allow_auto_merge - allow_merge_commit - allow_rebase_merge - allow_squash_merge - allow_update_branch (not defined in this code) - delete_branch_on_merge - merge_commit_message - merge_commit_title - squash_merge_commit_message - squash_merge_commit_title - use_squash_pr_title_as_default (not defined in this code) Therefore, I modified not to set these properties when target repository is already archived. Co-authored-by: Drift Check Updater <gh_actions_drift_check_updater@example.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1325
GitHub GET /repos/{owner}/{repo} API doesn't return some properties when repository is archived. https://docs.github.com/en/rest/repos/repos#get-a-repository
The difference between the results of running the API in the active repository and archived repositories is as follows:
https://gist.github.com/kangaechu/6cfaaf358bdda6726220f0248108b1fc
Therefore, I modified not to set these properties when target repository is already archived.