Add release assets#1195
Merged
kfcampbell merged 5 commits intointegrations:mainfrom Nov 8, 2022
shabbyrobe:release-assets
Merged
Add release assets#1195kfcampbell merged 5 commits intointegrations:mainfrom shabbyrobe:release-assets
kfcampbell merged 5 commits intointegrations:mainfrom
shabbyrobe:release-assets
Conversation
|
Hey 👋🏽 any news about this? |
|
It would be nice to have this feature! |
Contributor
|
@shabbyrobe Sorry for the delay! It looks like the build failure is related to a website linting error that can easily be fixed. I'd be happy to get this in once it is! As far as testing, I'm not sure. This is a great question and something I'm thinking about as well for #1120. Balancing the need for integration testing with the hassle of keeping several organizations and credentials current across several flavors of GitHub is obnoxious. My immediate, tentative vote would be to postpone integration testing this functionality until we have working integration tests in CI. |
Contributor
Author
|
Thanks for the update @kfcampbell, just fixed the typo, can you please re-approve the workflow? |
|
Thanks! |
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
* Add release assets * Add assets to release documentation * Fix typo in documentation Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
* Add release assets * Add assets to release documentation * Fix typo in documentation Co-authored-by: Keegan Campbell <me@kfcampbell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
assetsportion of Github releases to the output of the github release data source:Please let me know how I should test this; to run the tests it seems I needed to create a release and then pass the
GITHUB_TEMPLATE_REPOSITORY_RELEASE_ID=...env var. I can configure a test that anticipates that the release referenced by that env var must have at least one asset attached to it. I presume I'd document that requirement inCONTRIBUTING.md?