Fix asserts_url typo#1194
Merged
kfcampbell merged 4 commits intointegrations:mainfrom Nov 8, 2022
shabbyrobe:asserts-typo
Merged
Fix asserts_url typo#1194kfcampbell merged 4 commits intointegrations:mainfrom shabbyrobe:asserts-typo
kfcampbell merged 4 commits intointegrations:mainfrom
shabbyrobe:asserts-typo
Conversation
Contributor
Author
|
@kfcampbell - hope you don't mind me pushing my luck and pinging you on this one too 😄 This feels like it's relatively benign, do you think this is something that could be merged? |
kfcampbell
approved these changes
Nov 8, 2022
Contributor
kfcampbell
left a comment
There was a problem hiding this comment.
Thanks for bringing this up! This has always bothered me.
I wouldn't mind cutting a major release to remove the deprecated version at some point in the near future as well. I'd like to get in the habit of releasing more often.
Contributor
|
Integration tests are passing locally for me. |
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
* Fix assets_url typo * Add deprecation message * Follow instructions more closely Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
* Fix assets_url typo * Add deprecation message * Follow instructions more closely Co-authored-by: Keegan Campbell <me@kfcampbell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to revive #448, which seems to have stalled. The change is largely the same, but I have also followed the instructions for deprecation found here.