Skip to content

feat: allow_update_branch argument#1143

Merged
kfcampbell merged 2 commits intointegrations:mainfrom
strantalis:feat/always-suggest-updating-pr
Oct 27, 2022
Merged

feat: allow_update_branch argument#1143
kfcampbell merged 2 commits intointegrations:mainfrom
strantalis:feat/always-suggest-updating-pr

Conversation

@strantalis
Copy link
Copy Markdown
Contributor

@strantalis strantalis commented May 7, 2022

This argument allows toggling Always suggest updating pull request branch in the repository settings. Closes #1072 but is dependent by #1138 as this needs v44 of go-github.

@rene-bos
Copy link
Copy Markdown
Contributor

The dependent PR (#1138) has been merged, so I think nothing blocks this PR from being finalized and merged. @strantalis do you have time to fix the conflicts?

@strantalis
Copy link
Copy Markdown
Contributor Author

@rene-bos Yeah I can get those fixed this week.

setting allows toggling "always suggest updating pull request branch"
repository setting

Signed-off-by: Sean Trantalis <strantalis@virtru.com>
@strantalis strantalis force-pushed the feat/always-suggest-updating-pr branch from 4150a09 to d21bba0 Compare September 19, 2022 17:45
@EvyBongers
Copy link
Copy Markdown

When could this PR be merged?

@EvyBongers
Copy link
Copy Markdown

@bateller Can you approve the workflow? I'm hoping to see this PR merged soon, since it's blocking some work I have planned

@gesellix
Copy link
Copy Markdown
Contributor

This would be great to be included in the next release :)

@github-matthieu-wipliez
Copy link
Copy Markdown

Hi, I just stumbled upon this PR, great job 🎉 ! Looking forward to a merge 😁

@kfcampbell
Copy link
Copy Markdown
Contributor

I've updated the PR and fixed the merge conflict. I love this feature and we have it enabled on this repo! This will be released shortly.

@kfcampbell kfcampbell merged commit 49795e1 into integrations:main Oct 27, 2022
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
setting allows toggling "always suggest updating pull request branch"
repository setting

Signed-off-by: Sean Trantalis <strantalis@virtru.com>

Signed-off-by: Sean Trantalis <strantalis@virtru.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
setting allows toggling "always suggest updating pull request branch"
repository setting

Signed-off-by: Sean Trantalis <strantalis@virtru.com>

Signed-off-by: Sean Trantalis <strantalis@virtru.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Pull Requests] less Always suggest updating pull request branches avariable for the repository.

7 participants