Skip to content

Allow setting owner in anonymous mode#1029

Merged
kfcampbell merged 9 commits intointegrations:mainfrom
kfcampbell:allow-anonymous-owners
Oct 27, 2023
Merged

Allow setting owner in anonymous mode#1029
kfcampbell merged 9 commits intointegrations:mainfrom
kfcampbell:allow-anonymous-owners

Conversation

@kfcampbell
Copy link
Copy Markdown
Contributor

@kfcampbell kfcampbell commented Jan 8, 2022

Fixes #647.

The provider currently doesn't respect any ownership configuration when running in anonymous mode. This is annoying because it blocks all kinds of uses, for example data sources retrieving public repos.

This PR makes a small change to respect ownership in anonymous mode, and now those data sources work!

@kfcampbell
Copy link
Copy Markdown
Contributor Author

kfcampbell commented Jan 8, 2022

cc @Olin-Vorechovsky I'd rather do this than error if there's no token present, since there's a lot of valid use cases for the provider without auth configured IMO. Thoughts?

@kfcampbell kfcampbell added the v5 label Jan 18, 2022
@kfcampbell kfcampbell removed the v5 label Jan 31, 2022
@kfcampbell kfcampbell added this to the v4.21.0 milestone Jan 31, 2022
@kfcampbell
Copy link
Copy Markdown
Contributor Author

kfcampbell commented Jan 31, 2022

I think this is a worthwhile change and since it's not breaking backwards compatibility, I've added it to a future milestone for release.

@kfcampbell kfcampbell modified the milestones: v4.21.0, v4.22.0 Mar 3, 2022
@kfcampbell
Copy link
Copy Markdown
Contributor Author

kfcampbell commented Mar 3, 2022

@jcudit let's talk about this in the next week or two!

@kfcampbell kfcampbell removed this from the v4.22.0 milestone Mar 18, 2022
@nickfloyd nickfloyd added the Status: Stale Used by stalebot to clean house label Nov 30, 2022
@nickfloyd
Copy link
Copy Markdown
Member

nickfloyd commented Nov 30, 2022

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Dec 1, 2022
@kfcampbell
Copy link
Copy Markdown
Contributor Author

kfcampbell commented Dec 1, 2022

I had forgotten about this! I think this is still relevant and should be merged.

@kfcampbell kfcampbell mentioned this pull request Dec 9, 2022
Closed
@kfcampbell kfcampbell mentioned this pull request Jul 25, 2023
Closed
@kfcampbell kfcampbell mentioned this pull request Oct 25, 2023
Closed
4 tasks
@kfcampbell kfcampbell merged commit 1741133 into integrations:main Oct 27, 2023
@kfcampbell kfcampbell deleted the allow-anonymous-owners branch October 27, 2023 20:55
@kfcampbell kfcampbell mentioned this pull request Nov 21, 2023
Closed
1 task
@mnencia mnencia mentioned this pull request Dec 27, 2023
Merged
4 tasks
kfcampbell added a commit that referenced this pull request Jan 5, 2024
@mnencia @kfcampbell
Avoid getting user when anonymous (#2074)
7411f66 
Resolves regressions #2008 and #2014 introduced in #1029

Signed-off-by: Marco Nenciarini <mnencia@kcore.it>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@kfcampbell
Initial commit of allowing owners for anonymous auth (integrations#1029)
7503644
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@mnencia @kfcampbell
Avoid getting user when anonymous (integrations#2074)
a6fd873 
Resolves regressions integrations#2008 and integrations#2014 introduced in integrations#1029

Signed-off-by: Marco Nenciarini <mnencia@kcore.it>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

vNext

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

terraform-import failure: Cannot import non-existent remote object

2 participants

@kfcampbell @nickfloyd