Remove rhx_gis header support #2340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aandergr
reviewed
Aug 28, 2024
The query used to obtain it does not work anymore. The parameter was only used when obtaining a profile by its id, when not logged in. This query is working fine without the special header, so the whole functionality concerning rhx_gis was removed. This also fixes this misleading messages logged when trying to obtain a profile anonymously: JSON Query to : Expecting value: line 1 column 1 (char 0)
4961f6c to
fb643ea
Compare
Member
|
Thanks! |
exwm
pushed a commit
to exwm/instaloader
that referenced
this pull request
Aug 31, 2024
The query used to obtain it does not work anymore. The parameter was only used when obtaining a profile by its id, when not logged in. This query is working fine without the special header, so the whole functionality concerning rhx_gis was removed. This also fixes this misleading messages logged when trying to obtain a profile anonymously: JSON Query to : Expecting value: line 1 column 1 (char 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2338, and removes useless code.
The query used to obtain the
rhx_gisparameter (root_rhx_gisfunction) does not work anymore.The parameter was only used when obtaining a profile by its id, when not logged in. This query is working fine without the special header, so the whole functionality concerning rhx_gis was removed.
This also fixes this misleading messages logged when trying to obtain a profile anonymously:
Note that this has changed the signature of the
graphql_queryfunction. I'm not sure if it's part of the public API, but it's very low level, so I changed it anyway.