Fix uninitialized constant Parser::AST::Processor::Mixin by stanhu · Pull Request #7030 · inspec/inspec

stanhu · 2024-04-26T23:08:47Z

Description

parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure:

% bundle exec ruby -Itest test/unit/profiles/profile_test.rb
inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError)

        include Parser::AST::Processor::Mixin
                                      ^^^^^^^

Fix this by inherting from Parser::AST::Processor and requiring the right version of the parser gem.

Related Issue

Closes #7029

Types of changes

Bug fix (non-breaking change which fixes an issue)
New content (non-breaking change)
Breaking change (a content change which would break existing functionality or processes)

Checklist:

I have read the CONTRIBUTING document.

netlify · 2024-04-26T23:09:04Z

✅ Deploy Preview for chef-inspec canceled.

Name	Link
🔨 Latest commit	`d2ff553`
🔍 Latest deploy log	https://app.netlify.com/sites/chef-inspec/deploys/66317a4df4129600084e7ccd

lib/inspec/utils/profile_ast_helpers.rb

inspec.gemspec

parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` instead. Closes inspec#7029 Signed-off-by: Stan Hu <stanhu@gmail.com>

aaronlippold · 2024-05-01T19:33:26Z

What's the current work around for existing releases, like 6.6.0?

stanhu · 2024-05-01T19:40:36Z

What's the current work around for existing releases, like 6.6.0?

Use parser v3.3.0.5.

aaronlippold · 2024-05-01T20:04:13Z

Aka throw that in the Gemfile of my profile? Working to fix my current pipeline while we wait on the patch.

stanhu · 2024-05-01T20:07:42Z

Aka throw that in the Gemfile of my profile? Working to fix my current pipeline while we wait on the patch.

Yes, lock it down. 😄

aaronlippold · 2024-05-01T20:10:12Z

Cool, I will give that a try, or more specifically @wdower will :)

ruairiquinn-bv · 2024-05-02T08:13:06Z

What's the current work around for existing releases, like 6.6.0?

Use parser v3.3.0.5.

We tried this but without much success, any idea when this fix will be merged?

[2024-05-01T16:45:21.517Z] Fetching gem metadata from https://rubygems.org/........
[2024-05-01T16:45:22.032Z] Resolving dependencies....
[2024-05-01T16:45:22.032Z] Bundler could not find compatible versions for gem "parser":
[2024-05-01T16:45:22.032Z]   In Gemfile:
[2024-05-01T16:45:22.032Z]     parser (= 3.3.0.5)
[2024-05-01T16:45:22.032Z] 
[2024-05-01T16:45:22.032Z]     kitchen-inspec was resolved to 2.6.2, which depends on
[2024-05-01T16:45:22.032Z]       inspec (>= 2.2.64, < 6.0) was resolved to 5.22.40, which depends on
[2024-05-01T16:45:22.032Z]         cookstyle was resolved to 7.32.8, which depends on
[2024-05-01T16:45:22.032Z]           rubocop (= 1.25.1) was resolved to 1.25.1, which depends on\
[2024-05-01T16:45:22.032Z] rubocop-ast (>= 1.15.1, < 2.0) was resolved to 1.31.3, which depends
[2024-05-01T16:45:22.032Z] on
[2024-05-01T16:45:22.032Z]               parser (>= 3.3.1.0)

ahasunos · 2024-05-02T08:30:49Z

What's the current work around for existing releases, like 6.6.0?

Use parser v3.3.0.5.

We tried this but without much success, any idea when this fix will be merged?

[2024-05-01T16:45:21.517Z] Fetching gem metadata from https://rubygems.org/........
[2024-05-01T16:45:22.032Z] Resolving dependencies....
[2024-05-01T16:45:22.032Z] Bundler could not find compatible versions for gem "parser":
[2024-05-01T16:45:22.032Z]   In Gemfile:
[2024-05-01T16:45:22.032Z]     parser (= 3.3.0.5)
[2024-05-01T16:45:22.032Z] 
[2024-05-01T16:45:22.032Z]     kitchen-inspec was resolved to 2.6.2, which depends on
[2024-05-01T16:45:22.032Z]       inspec (>= 2.2.64, < 6.0) was resolved to 5.22.40, which depends on
[2024-05-01T16:45:22.032Z]         cookstyle was resolved to 7.32.8, which depends on
[2024-05-01T16:45:22.032Z]           rubocop (= 1.25.1) was resolved to 1.25.1, which depends on\
[2024-05-01T16:45:22.032Z] rubocop-ast (>= 1.15.1, < 2.0) was resolved to 1.31.3, which depends
[2024-05-01T16:45:22.032Z] on
[2024-05-01T16:45:22.032Z]               parser (>= 3.3.1.0)

It would be merged today!

parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` instead. Closes #7029 Signed-off-by: Stan Hu <stanhu@gmail.com>

parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` instead. Closes #7029 Signed-off-by: Stan Hu <stanhu@gmail.com> Co-authored-by: Stan Hu <stanhu@gmail.com>

stanhu · 2024-05-02T12:56:43Z

We tried this but without much success

It looks like rubocop-ast 1.31.3 was updated to require parser >= 3.3.1.0 (https://rubygems.org/gems/rubocop-ast) via rubocop/rubocop-ast#289.

Locking rubocop-ast to 1.31.2 and parser to 3.3.0.5 would be the current workaround.

aaronlippold · 2024-05-02T16:50:52Z

That works for me

…

-------- Aaron Lippold ***@***.*** 260-255-4779 twitter/aim/yahoo,etc. 'aaronlippold'

On Wed, May 1, 2024 at 16:10 Aaron Lippold ***@***.***> wrote: Cool, I will give that a try, or more specifically @wdower <https://github.com/wdower> will :) — Reply to this email directly, view it on GitHub <#7030 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALK42CJMJEERVNS2KAE3FDZAFD3VAVCNFSM6AAAAABG3RHCJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBZGA2TOOBQHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

stanhu · 2024-05-02T16:55:29Z

@ahasunos I see there is a v6.6.19 tag with this change (9939b0d), but https://rubygems.org/gems/inspec still only shows 6.6.0 published. Do you know what it takes to publish this to RubyGems?

ruairiquinn-bv · 2024-05-03T07:20:27Z

We tried this but without much success

It looks like rubocop-ast 1.31.3 was updated to require parser >= 3.3.1.0 (https://rubygems.org/gems/rubocop-ast) via rubocop/rubocop-ast#289.

Locking rubocop-ast to 1.31.2 and parser to 3.3.0.5 would be the current workaround.

Thanks, that did the trick!

Due to inspec/inspec#7029, omnibus-gitlab will not work if parser 3.3.1.0 and up are installed. Patch the gem with inspec/inspec#7030 until an update is available. This will avoid failures if parser 3.3.1.0 is installed and prevent incidents such as https://gitlab.com/gitlab-com/gl-infra/production/-/issues/17954. Changelog: fixed

parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` instead. Closes #7029 Signed-off-by: Stan Hu <stanhu@gmail.com>

Due to inspec/inspec#7029, omnibus-gitlab will not work if parser 3.3.1.0 and up are installed. Patch the gem with inspec/inspec#7030 until an update is available. This will avoid failures if parser 3.3.1.0 is installed and prevent incidents such as https://gitlab.com/gitlab-com/gl-infra/production/-/issues/17954. Changelog: fixed

parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` instead. Closes #7029 Signed-off-by: Stan Hu <stanhu@gmail.com>

stanhu requested a review from a team as a code owner April 26, 2024 23:08

stanhu requested review from ahasunos and clintoncwolfe April 26, 2024 23:08

stanhu force-pushed the sh-fix-issue-7029 branch from d459348 to ad55c9a Compare April 26, 2024 23:09

ahasunos approved these changes Apr 29, 2024

View reviewed changes

ahasunos reviewed Apr 30, 2024

View reviewed changes

lib/inspec/utils/profile_ast_helpers.rb Show resolved Hide resolved

ahasunos reviewed Apr 30, 2024

View reviewed changes

inspec.gemspec Outdated Show resolved Hide resolved

stanhu force-pushed the sh-fix-issue-7029 branch from ad55c9a to 9defb88 Compare April 30, 2024 23:09

stanhu force-pushed the sh-fix-issue-7029 branch from 9defb88 to d2ff553 Compare April 30, 2024 23:10

ahasunos merged commit c9bb58e into inspec:main May 2, 2024

ahasunos mentioned this pull request May 2, 2024

Backport-7030: Fix uninitialized constant Parser::AST::Processor::Mixin (#7030) #7036

Merged

4 tasks

stanhu mentioned this pull request May 13, 2024

uninitialized constant Parser::AST::Processor::Mixin with parser 3.3.1.0 #7029

Closed

Conversation

stanhu commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Types of changes

Checklist:

Uh oh!

netlify bot commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for chef-inspec canceled.

Uh oh!

Uh oh!

Uh oh!

aaronlippold commented May 1, 2024

Uh oh!

stanhu commented May 1, 2024

Uh oh!

aaronlippold commented May 1, 2024

Uh oh!

stanhu commented May 1, 2024

Uh oh!

aaronlippold commented May 1, 2024

Uh oh!

ruairiquinn-bv commented May 2, 2024

Uh oh!

ahasunos commented May 2, 2024

Uh oh!

stanhu commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronlippold commented May 2, 2024 via email

Uh oh!

stanhu commented May 2, 2024

Uh oh!

ruairiquinn-bv commented May 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stanhu commented Apr 26, 2024 •

edited

Loading

netlify bot commented Apr 26, 2024 •

edited

Loading

stanhu commented May 2, 2024 •

edited

Loading