Pin Thor to < 1.3.0 to fix test failures related to aliases#6815
Merged
Conversation
✅ Deploy Preview for chef-inspec canceled.
|
ahasunos
approved these changes
Oct 23, 2023
Contributor
There was a problem hiding this comment.
This is one of the potential fix which fixes the CI test. Thor 1.3.0 released recently breaks our current test.
If we are sure that fixing only the test is not going to affect our other functionality, we can go ahead and fix the test and remove the constraint to use thor below 1.3.0
Contributor
|
This will require a backport to inspec-5 and inspec-4 |
…) which started breaking the test. Till we find if recent release is stable and don't break any functionality we are pinning thor to < 1.3.0 Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
d7a6ea9 to
7583474
Compare
This was referenced Oct 23, 2023
chef-expeditor Bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
Obvious fix; these changes are the result of automation not creative thinking.
Nik08
pushed a commit
that referenced
this pull request
Sep 13, 2024
…) which started breaking the test. Till we find if recent release is stable and don't break any functionality we are pinning thor to < 1.3.0 (#6815) Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
Nik08
pushed a commit
that referenced
this pull request
Sep 13, 2024
Obvious fix; these changes are the result of automation not creative thinking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Thor's recent release version 1.3.0 they introduced changes related to aliases here rails/thor#800
that started breaking the inspec test for aliases. This PR pins the version of Thor to be < 1.3.0 and then we can identify the impact of the Thor changes in InSpec and then remove the pinning.
Related Issue
Types of changes
Checklist: