various bugs-fix in ts2vel.py --periodic and prep_hyp3#822
Merged
yunjunz merged 5 commits intoinsarlab:mainfrom Jul 28, 2022
Merged
various bugs-fix in ts2vel.py --periodic and prep_hyp3#822yunjunz merged 5 commits intoinsarlab:mainfrom
ts2vel.py --periodic and prep_hyp3#822yunjunz merged 5 commits intoinsarlab:mainfrom
Conversation
…e while --write-data
+ use atan2(), instead of atan(), to account for the 4 quadrant outcome of arc tangent, while calculating the phase component of the periodic signals.
ts2vel.py --periodic and prep_hyp3 for ORBIT_DIR*ts2vel.py --periodic and prep_hyp3
ts2vel.py --periodic and prep_hyp3ts2vel.py --periodic and prep_hyp3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
timeseries2velocity.py --periodic: useatan2(), instead ofatan(), to account for the 4 quadrant outcome of the arc tangent operation, while calculating the phase component of the periodic signals. Identified by @yjzhenglamarmota and fixed by @piyushrpt.prep_hyp3.py: fix bug ofORBIT_DIRECTIONintroduced in hyp3: fix incAngle/slantRangeDist + add more attributes (pass full test) #640. Identified and fixed by Lavosianne Souza and Adrian Borsa from UCSD.reference_point.py inputs/ifgramStack.h5 --write-data: skip pixels with no-data-value (zero) while updating theunwrapPhasematrix.README.mdandsetup.py: switch MintPy license fromGPLv3toGPLv3+, as discussed in Licensing PySolid#35.Reminders