Skip to content

hyp3: fix incAngle/slantRangeDist + add more attributes (pass full test)#640

Merged
yunjunz merged 2 commits intoinsarlab:mainfrom
yunjunz:hyp3
Aug 14, 2021
Merged

hyp3: fix incAngle/slantRangeDist + add more attributes (pass full test)#640
yunjunz merged 2 commits intoinsarlab:mainfrom
yunjunz:hyp3

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Aug 14, 2021

Description of proposed changes

This PR adds the following changes for hyp3 related data loading process/documentation. With the example dataset on Ridgecrest that @cirrusasf provided (https://jzhu-hyp3-dev.s3.us-west-2.amazonaws.com/hyp3-mintpy/Ridgecrest.zip), I have been able to use tropospheric correction and dem error correction as expected, so the hyp3 + mintpy workflow is fully functioning in my opinion (#540), except for the following two aspects:

One small issue is the DEM error correction for the specific Ridgecrest EQ, when we specify a step function on July 4, but the current code could not distinguish if the step func (EQ) happens before or after the SAR acquisition on the same day. This should be an easy fix, will do it in another PR since it's not really related to hyp3. [Update: fixed in #661]

Another is the UTM coordinated related issues: mintpy is by default expecting lat/lon in degrees, thus, a lot of geo-related script/functions might not work well with UTM coordinates. The detailed number of changes is unknown, I created a milestone to keep track of future related changes: https://github.com/insarlab/MintPy/milestone/6.

  • prep_hyp3:

  • stackDict: convert Gamma inc angle to isce/mintpy inc angle convention while loading the data

  • docs/dir_structure.hyp3:

    • remove warning for inc angle as the latest HyP3 is producing the correct one now
    • add geometry file path in the template for incidence angle and water mask
    • use Ridgecrest SenT71 dataset for the example in the directory structure

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI / local test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ prep_hyp3:
   - ensure negative HEADING value
   - grab CENTER_LINE_UTC from UTCtime directly
   - put P_BASELINE_* to the ifgram specific metadata
   - add STARTING_RANGE from "Slant range near"
   - add RANGE/AZIMUTH_PIXEL_SIZE from hardwired Sentinel-1 info
   - adjust to the new incidence angle file name 'lv_theta'

+ stackDict:
   - convert Gamma inc angle to isce/mintpy inc angle convention while loading the data for hyp3
   - consider the above conversion while calc slantRangeDistance from incidence angle for hyp3
+ remove warning for inc angle as the latest HyP3 is producing the correct one now
+ add geometry file path in the template for incidence angle and water mask
+ use Ridgecrest SenT71 dataset for the example in the directory structure
@yunjunz yunjunz changed the title hyp3: update geom & docs + pass full test hyp3: add incAngle/slantRangeDist + more attributes (pass full test) Aug 14, 2021
@yunjunz yunjunz changed the title hyp3: add incAngle/slantRangeDist + more attributes (pass full test) hyp3: fix incAngle/slantRangeDist + add more attributes (pass full test) Aug 14, 2021
@yunjunz yunjunz merged commit 9cbc317 into insarlab:main Aug 14, 2021
@yunjunz yunjunz deleted the hyp3 branch August 14, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant