hyp3: fix incAngle/slantRangeDist + add more attributes (pass full test)#640
Merged
yunjunz merged 2 commits intoinsarlab:mainfrom Aug 14, 2021
Merged
hyp3: fix incAngle/slantRangeDist + add more attributes (pass full test)#640yunjunz merged 2 commits intoinsarlab:mainfrom
yunjunz merged 2 commits intoinsarlab:mainfrom
Conversation
+ prep_hyp3: - ensure negative HEADING value - grab CENTER_LINE_UTC from UTCtime directly - put P_BASELINE_* to the ifgram specific metadata - add STARTING_RANGE from "Slant range near" - add RANGE/AZIMUTH_PIXEL_SIZE from hardwired Sentinel-1 info - adjust to the new incidence angle file name 'lv_theta' + stackDict: - convert Gamma inc angle to isce/mintpy inc angle convention while loading the data for hyp3 - consider the above conversion while calc slantRangeDistance from incidence angle for hyp3
+ remove warning for inc angle as the latest HyP3 is producing the correct one now + add geometry file path in the template for incidence angle and water mask + use Ridgecrest SenT71 dataset for the example in the directory structure
6 tasks
5 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds the following changes for
hyp3related data loading process/documentation. With the example dataset on Ridgecrest that @cirrusasf provided (https://jzhu-hyp3-dev.s3.us-west-2.amazonaws.com/hyp3-mintpy/Ridgecrest.zip), I have been able to use tropospheric correction and dem error correction as expected, so thehyp3 + mintpyworkflow is fully functioning in my opinion (#540), except for the following two aspects:One small issue is the DEM error correction for the specific Ridgecrest EQ, when we specify a step function on July 4, but the current code could not distinguish if the step func (EQ) happens before or after the SAR acquisition on the same day. This should be an easy fix, will do it in another PR since it's not really related to hyp3. [Update: fixed in #661]
Another is the UTM coordinated related issues: mintpy is by default expecting lat/lon in degrees, thus, a lot of geo-related script/functions might not work well with UTM coordinates. The detailed number of changes is unknown, I created a milestone to keep track of future related changes: https://github.com/insarlab/MintPy/milestone/6.
prep_hyp3:
stackDict: convert Gamma inc angle to isce/mintpy inc angle convention while loading the data
docs/dir_structure.hyp3:
Reminders