Skip to content

plot_transection: bugfix for add_arrow()#778

Merged
yunjunz merged 3 commits intoinsarlab:mainfrom
yunjunz:transect
May 23, 2022
Merged

plot_transection: bugfix for add_arrow()#778
yunjunz merged 3 commits intoinsarlab:mainfrom
yunjunz:transect

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented May 23, 2022

Description of proposed changes

Reminders

yunjunz added 3 commits May 23, 2022 14:33
+ utils/plot.plot_colorbar(): use len(unique_values) instead of cmap_lut while checking for discrete colorbar ticks
+ view: rm the useless plt.subplots(num), as it shows up in notebooks with %matplotlib widget
+ docs/installation: minor comment simplification
+ iono_tec: printout CENTER_LINE_UTC and local solar time

+ diff.check_reference(): simple refactor and bugfix when file1 is absolute w/o REF_DATE.
+ fix the "IndexError: index 2 is out of bounds for axis 0 with size 2"
@yunjunz yunjunz requested a review from yjzhenglamarmota May 23, 2022 21:37
@yunjunz
Copy link
Member Author

yunjunz commented May 23, 2022

@yjzhenglamarmota thank you for sending your data offline. I was able to reproduce the error. Could you please confirm whether this PR fix the issue on your end?

@yunjunz yunjunz changed the title Transect plot_transection: bugfix for add_arrow() May 23, 2022
@yjzhenglamarmota
Copy link
Contributor

@yjzhenglamarmota thank you for sending your data offline. I was able to reproduce the error. Could you please confirm whether this PR fix the issue on your end?

Yes, thank you!
I still have issues with zooming in and selecting points, but that may be due to some specific configuration of my laptop.

Copy link
Contributor

@yjzhenglamarmota yjzhenglamarmota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original issue is resolved.

@yunjunz yunjunz merged commit 6e592f8 into insarlab:main May 23, 2022
@yunjunz yunjunz deleted the transect branch May 23, 2022 22:23
yuankailiu pushed a commit to yuankailiu/MintPy that referenced this pull request Jun 2, 2022
+ plot_transection.py: fix the "IndexError: index 2 is out of bounds for axis 0 with size 2" due to utils/plot.add_arrow()

+ utils/plot.plot_colorbar(): use len(unique_values) instead of cmap_lut while checking for discrete colorbar ticks

+ view: rm the useless plt.subplots(num), as it shows up in notebooks with %matplotlib widget

+ iono_tec: printout CENTER_LINE_UTC and local solar time

+ diff.check_reference(): simple refactor and bugfix when file1 is absolute w/o REF_DATE.

+ docs/installation: minor comment simplification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add_arrow does not support geocoded file in plot_transections.py

2 participants