Skip to content

add mintpy.unwrapError.connCompMinArea option#719

Merged
yunjunz merged 8 commits intoinsarlab:mainfrom
mirzaees:hardcoded_values
Jan 13, 2022
Merged

add mintpy.unwrapError.connCompMinArea option#719
yunjunz merged 8 commits intoinsarlab:mainfrom
mirzaees:hardcoded_values

Conversation

@mirzaees
Copy link
Collaborator

@mirzaees mirzaees commented Jan 11, 2022 •
edited by yunjunz
Loading

Description of proposed changes

Some of the parameters which were hardcoded, are change to be optional.

  1. The step size in solid earth tide function (made adaptive based on input file info)
  2. The min_area in label_conn_comp (added an option in template)
  3. Added support for slcStack to read slice list

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@mirzaees mirzaees requested a review from yunjunz January 11, 2022 20:32
@yunjunz yunjunz linked an issue Jan 12, 2022 that may be closed by this pull request
Hardcoded values sometimes do not work #718
Closed
@yunjunz
Copy link
Member

yunjunz commented Jan 12, 2022 •
edited
Loading

Thank you @mirzaees for the improvements.

Your change in the readfile.get_slice_list() won't affect existing functionality, which is good. I am just curious on your logic behind: we identify the FILE_TYPE via the h5 dataset name timeseries in the root level, and your change seems to assume a h5 dataset name slc in the root level, thus, I don't think it will work, isn't it?

Related to the above, I am curious how you distinguish between the displacement time series and the SLC stack in general in minopy? I assume one way is the DATA_TYPE (float32 vs complex64).

@mirzaees
Copy link
Collaborator Author

mirzaees commented Jan 12, 2022

For slcStack, the dataset name is slc but the file type is timeseries, minopy has a slcStack.py module similar to mintpy stack.py to make it. File type was previously SLC too but some of the mintpy functions did not work so that is now changed to timeseries. One way to distinguish is data type as you mentioned and the dataset name is also different.

yunjunz
yunjunz approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation @mirzaees. Looks all good to me.

@yunjunz yunjunz changed the title making some hardcoded values optional and adaptive add mintpy.unwrapError.connCompMinArea option Jan 13, 2022
@yunjunz yunjunz merged commit 9b66885 into insarlab:main Jan 13, 2022
@mirzaees mirzaees deleted the hardcoded_values branch June 29, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yunjunz yunjunz yunjunz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hardcoded values sometimes do not work

2 participants

@mirzaees @yunjunz