Skip to content

Hardcoded values sometimes do not work #718

@mirzaees

Description

@mirzaees

Description of the issue

There are a few things that are hardcoded and sometimes do not adapt with full res data.
So I sometimes get error or the step is skipped. I am listing two here:

  1. The step size in solid earth tide function (It is a large value, when I set it to 3e2, it works):

    step_size=3e3,

  2. The min_area in label_conn_comp (It is a large value, when I set it to 2.5e2, it works):

    label_img, num_label = conncomp.label_conn_comp(cc_mask, min_area=2.5e3, print_msg=True)

Describe the solution you'd like

I am not sure what is a good solution, whether to change the hardcoded values or make them as an option in template.
@yunjunz please let me know what you think may solve this issue and I will be happy to help. Although you know better where else this could happen.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions