Skip to content

fix argv bug in view.py for pip installed version#714

Merged
yunjunz merged 2 commits intoinsarlab:mainfrom
yunjunz:bugfix
Dec 23, 2021
Merged

fix argv bug in view.py for pip installed version#714
yunjunz merged 2 commits intoinsarlab:mainfrom
yunjunz:bugfix

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Dec 21, 2021

Description of proposed changes

  • view.py: catch the manually specified arguments via sys.argv for cmd or via iargs through python call, and save it to inps.argv for later-on checking. Fixed the same issue in save_gbis.py as well. Fix arg less main() for pip install -e yunjunz/MintPy#5.

  • view.py: add --math rad2deg/deg2rad

  • utils0: add round_up_to_odd()

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI / local test (green)
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

github bot: fix typo
+ catch the manually specified arguments via `sys.argv` for cmd or via `iargs` through python call, and save it to `inps.argv` for later-on checking. Fixed the same issue in save_gbis.py as well.

+ add --math rad2deg/deg2rad
@yunjunz yunjunz requested a review from jhkennedy December 21, 2021 03:57
@yunjunz yunjunz changed the title Bugfix fix argv bug in view.py Dec 21, 2021
@yunjunz yunjunz changed the title fix argv bug in view.py fix argv bug in view.py for pip installed version Dec 21, 2021
@yunjunz yunjunz merged commit 7fb4108 into insarlab:main Dec 23, 2021
@yunjunz yunjunz deleted the bugfix branch December 23, 2021 00:33
EJFielding pushed a commit to EJFielding/MintPy that referenced this pull request Jan 9, 2022
+ utils0: add round_up_to_odd()

+ github bot: fix typo

+ view: fix argv bug for pip installed version. Catch the manually specified arguments via `sys.argv` for cmd or via `iargs` through python call, and save it to `inps.argv` for later-on checking. Fixed the same issue in save_gbis.py as well.

+ view: add `--math rad2deg/deg2rad`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

arg less main() for pip install -e

1 participant