Skip to content

set matplotlib<3.5 temporarily due to upstream repo bug#704

Merged
yunjunz merged 1 commit intoinsarlab:mainfrom
yunjunz:mpl
Nov 23, 2021
Merged

set matplotlib<3.5 temporarily due to upstream repo bug#704
yunjunz merged 1 commit intoinsarlab:mainfrom
yunjunz:mpl

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Nov 23, 2021

Description of proposed changes

set matplotlib<3.5 temporarily due to upstream repo bug (matplotlib/matplotlib#21711), which leads error while saving figures to PDF files.

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI / local test (green)

which leads error while saving figures to PDF files.
@yunjunz yunjunz requested a review from jhkennedy November 23, 2021 00:13
Copy link
Collaborator

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Might be worth making an issue for unpinning this dependency so we don't for get about it in the future.

@yunjunz
Copy link
Member Author

yunjunz commented Nov 23, 2021

Good idea @jhkennedy, I opened a new issue for that as reminders.

@yunjunz yunjunz merged commit d76edb9 into insarlab:main Nov 23, 2021
@yunjunz yunjunz deleted the mpl branch November 23, 2021 01:54
yunjunz added a commit to yunjunz/MintPy that referenced this pull request Nov 27, 2021
yunjunz added a commit to yunjunz/MintPy that referenced this pull request Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants