bugfix for coord.lalo2yx() when lat/lon have diff sizes#1160
Merged
yunjunz merged 3 commits intoinsarlab:mainfrom Mar 18, 2024
Merged
bugfix for coord.lalo2yx() when lat/lon have diff sizes#1160yunjunz merged 3 commits intoinsarlab:mainfrom
coord.lalo2yx() when lat/lon have diff sizes#1160yunjunz merged 3 commits intoinsarlab:mainfrom
Conversation
+ objects.coord.coordinate: - _clean_coord(): 1) take two arg instead of one, and ensure the two coords have the same size; 2) support None - lalo2yx/yx2lalo(): support None as inputs + subset.subset_input_dict2box(): use None as input to convert one type of coord only. + utils.arg_utils.add_subset_argument(): remove the unused option name alias (--suby/x/lat/lon), as they are not very readable and not frequently used.
ehavazli
pushed a commit
to ehavazli/MintPy
that referenced
this pull request
Mar 19, 2024
) + `objects.coord.coordinate`: - `_clean_coord()`: 1) take two arg instead of one, and ensure the two coords have the same size; 2) support `None` as input - `lalo2yx/yx2lalo()`: support `None` as inputs + `subset.subset_input_dict2box()`: use `None` as input to convert one type of coord only. + `utils.arg_utils.add_subset_argument()`: remove the unused option name alias (`--suby/x/lat/lon`), as they are not very readable and not frequently used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
objects.coord.coordinate:_clean_coord(): 1) take two arg instead of one, and ensure the two coords have the same size, following the changes in UTM support forview --show-gps+ dual-coord input forlalo2yx/yx2lalo()#1153; 2) supportNoneas inputlalo2yx/yx2lalo(): supportNoneas inputssubset.subset_input_dict2box(): useNoneas input to convert one type of coord only.utils.arg_utils.add_subset_argument(): remove the unused option name alias (--suby/x/lat/lon), as they are not very readable and not frequently used.Reminders