Skip to content

Upgrade assertions#9746

Closed
wouterdb wants to merge 1 commit intomasterfrom
issue/fix_reset_test
Closed

Upgrade assertions#9746
wouterdb wants to merge 1 commit intomasterfrom
issue/fix_reset_test

Conversation

@wouterdb
Copy link
Copy Markdown
Contributor

Description

Fix unstable test

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Attached issue to pull request
  • Changelog entry
  • Type annotations are present
  • Code is clear and sufficiently documented
  • No (preventable) type errors (check using make mypy or make mypy-diff)
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
  • If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

@wouterdb wouterdb requested a review from arnaudsjs November 18, 2025 10:01
@wouterdb wouterdb added the merge-tool-ready This ticket is ready to be merged in label Nov 18, 2025
@inmantaci
Copy link
Copy Markdown
Contributor

Processing this pull request

inmantaci pushed a commit that referenced this pull request Nov 18, 2025
# Description

Fix unstable test

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@inmantaci
Copy link
Copy Markdown
Contributor

Merged into branches master in 0d45898

inmantaci pushed a commit that referenced this pull request Nov 18, 2025
# Description

Fix unstable test

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@inmantaci inmantaci closed this Nov 18, 2025
@inmantaci inmantaci deleted the issue/fix_reset_test branch November 18, 2025 10:54
@inmantaci
Copy link
Copy Markdown
Contributor

Processing #9748.

inmantaci pushed a commit that referenced this pull request Nov 18, 2025
Pull request opened by the merge tool on behalf of #9746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-tool-ready This ticket is ready to be merged in

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants