Skip to content

update db update adr#9567

Closed
Hugo-Inmanta wants to merge 6 commits intomasterfrom
issue/update-db-update-adr
Closed

update db update adr#9567
Hugo-Inmanta wants to merge 6 commits intomasterfrom
issue/update-db-update-adr

Conversation

@Hugo-Inmanta
Copy link
Copy Markdown
Contributor

@Hugo-Inmanta Hugo-Inmanta commented Sep 16, 2025

Description

Spawned from a comment during standup.

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Attached issue to pull request
  • Changelog entry
  • Type annotations are present
  • Code is clear and sufficiently documented
  • No (preventable) type errors (check using make mypy or make mypy-diff)
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
  • If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Comment on lines +78 to +80
* Download a dump of the mgmt orchestrator
* Setup a dev orchestrator with the latest version of the database
* Load the dump and check that migration is successful
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a silly question, but is this safe ? Won't this result in the infra being managed by 2 different orchestrators at the same time ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but there is a trick: you need to set all environments to halted when restoring the dump

The support tool does that automatically
https://internal.inmanta.com/development/core/tasks/investigate-customer-issue
https://github.com/inmanta/inmanta-support/blob/master/src/inmanta_support/importers.py#L236

UPDATE public.environment SET halted = true

Copy link
Copy Markdown
Contributor

@wouterdb wouterdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I answered the question


For big database updates (e.g. large surface area / large structural changes...):

* Download a dump of the mgmt orchestrator
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not via support archive

Hugo-Inmanta and others added 2 commits September 16, 2025 15:24
Co-authored-by: Sander Van Balen <git@sandervanbalen.be>
@Hugo-Inmanta Hugo-Inmanta self-assigned this Sep 17, 2025
@Hugo-Inmanta Hugo-Inmanta added the merge-tool-ready This ticket is ready to be merged in label Sep 29, 2025
@inmantaci
Copy link
Copy Markdown
Contributor

Processing this pull request

inmantaci pushed a commit that referenced this pull request Sep 29, 2025
# Description

Spawned from a comment during standup.

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
inmantaci pushed a commit that referenced this pull request Sep 29, 2025
# Description

Spawned from a comment during standup.

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@inmantaci
Copy link
Copy Markdown
Contributor

Merged into branches master in 927a24d

inmantaci pushed a commit that referenced this pull request Sep 29, 2025
# Description

Spawned from a comment during standup.

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@inmantaci inmantaci closed this Sep 29, 2025
@inmantaci inmantaci deleted the issue/update-db-update-adr branch September 29, 2025 08:33
@inmantaci
Copy link
Copy Markdown
Contributor

Processing #9614.

inmantaci pushed a commit that referenced this pull request Sep 29, 2025
Pull request opened by the merge tool on behalf of #9567
@inmantaci
Copy link
Copy Markdown
Contributor

Processing #9615.

inmantaci pushed a commit that referenced this pull request Sep 29, 2025
Pull request opened by the merge tool on behalf of #9567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-tool-ready This ticket is ready to be merged in

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants