Skip to content

add missing defaults#9346

Closed
Hugo-Inmanta wants to merge 4 commits intomasterfrom
issue-8801-follow-up-fix-missing-default-in-constructor
Closed

add missing defaults#9346
Hugo-Inmanta wants to merge 4 commits intomasterfrom
issue-8801-follow-up-fix-missing-default-in-constructor

Conversation

@Hugo-Inmanta
Copy link
Copy Markdown
Contributor

Description

follow up fix to github.com//pull/9306

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Attached issue to pull request
  • Changelog entry
  • Type annotations are present
  • Code is clear and sufficiently documented
  • No (preventable) type errors (check using make mypy or make mypy-diff)
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
  • If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

@Hugo-Inmanta Hugo-Inmanta requested a review from wouterdb July 10, 2025 10:41
@Hugo-Inmanta Hugo-Inmanta added the merge-tool-ready This ticket is ready to be merged in label Jul 10, 2025
@inmantaci
Copy link
Copy Markdown
Contributor

Processing this pull request

inmantaci pushed a commit that referenced this pull request Jul 10, 2025
# Description

follow up fix to github.com//pull/9306

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@inmantaci
Copy link
Copy Markdown
Contributor

Merged into branches master in 4e06faf

inmantaci pushed a commit that referenced this pull request Jul 10, 2025
# Description

follow up fix to github.com//pull/9306

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
@inmantaci inmantaci closed this Jul 10, 2025
@inmantaci inmantaci deleted the issue-8801-follow-up-fix-missing-default-in-constructor branch July 10, 2025 11:43
@inmantaci
Copy link
Copy Markdown
Contributor

Processing #9348.

inmantaci pushed a commit that referenced this pull request Jul 10, 2025
Pull request opened by the merge tool on behalf of #9346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-tool-ready This ticket is ready to be merged in

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants