Skip to content

improved partial compile documentation for LSM#5443

Closed
sanderr wants to merge 8 commits intomasterfrom
issue/1132-partial-compile-lsm-improved-docs
Closed

improved partial compile documentation for LSM#5443
sanderr wants to merge 8 commits intomasterfrom
issue/1132-partial-compile-lsm-improved-docs

Conversation

@sanderr
Copy link
Copy Markdown
Contributor

@sanderr sanderr commented Jan 27, 2023

Description

closes inmanta/inmanta-lsm#1132

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Attached issue to pull request
  • Changelog entry
  • Type annotations are present
  • Code is clear and sufficiently documented
  • No (preventable) type errors (check using make mypy or make mypy-diff)
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

@sanderr sanderr marked this pull request as ready for review January 27, 2023 15:31
Comment thread docs/model_developers/resource_sets.rst Outdated
Comment thread docs/model_developers/resource_sets.rst Outdated
sanderr and others added 2 commits January 30, 2023 10:08
Co-authored-by: arnaudsjs <2684622+arnaudsjs@users.noreply.github.com>
@sanderr sanderr requested a review from arnaudsjs January 30, 2023 09:22
….com:inmanta/inmanta-core into issue/1132-partial-compile-lsm-improved-docs
@sanderr sanderr added the merge-tool-ready This ticket is ready to be merged in label Jan 30, 2023
@inmantaci
Copy link
Copy Markdown
Contributor

Processing this pull request

inmantaci pushed a commit that referenced this pull request Jan 30, 2023
# Description

closes inmanta/inmanta-lsm#1132

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Attached issue to pull request
- [x] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
@inmantaci
Copy link
Copy Markdown
Contributor

Merged into branches master, iso6 in 01c5f88

@inmantaci inmantaci closed this Jan 30, 2023
@inmantaci inmantaci deleted the issue/1132-partial-compile-lsm-improved-docs branch January 30, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-tool-ready This ticket is ready to be merged in

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants