Skip to content

Adding $associationsContext property to models#20

Merged
infograf768 merged 1 commit intoinfograf768:assoc_deletionfrom
Bakual:assoc_deletion
Jul 31, 2015
Merged

Adding $associationsContext property to models#20
infograf768 merged 1 commit intoinfograf768:assoc_deletionfrom
Bakual:assoc_deletion

Conversation

@Bakual
Copy link
Copy Markdown

@Bakual Bakual commented Jul 30, 2015

My suggestion to use the new property.
This would be completely B/C as it doesn't change anything for 3rd party extensions.
They need to add the $associationsContext to their model to have it run this code.

@Bakual
Copy link
Copy Markdown
Author

Bakual commented Jul 30, 2015

Hope I didn't miss a core extension which uses associations.

@infograf768
Copy link
Copy Markdown
Owner

Not sure this is fully correct.
Let's say that a 3rd party component is using associations and is using com_xxx.item as context.
The extension will not have yet $associationsContext defined.
I suggest to take this into account as I proposed in the PR.
This would help these extensions until they implement $associationsContext

@infograf768
Copy link
Copy Markdown
Owner

Forget it: they lived without it until now. We just have to advertise this in a meaningful manner.
I merge. Thanks.

infograf768 added a commit that referenced this pull request Jul 31, 2015
Adding $associationsContext property to models
@infograf768 infograf768 merged commit e5a1f86 into infograf768:assoc_deletion Jul 31, 2015
@Bakual Bakual deleted the assoc_deletion branch July 31, 2015 20:11
infograf768 pushed a commit that referenced this pull request Jun 3, 2017
* codestyle

* code style

* codestyle

* codestyle

* codestyle

* thanks @wojsmol

* corrections - thanks @Quy

* corrections - thanks @Quy

* oops

* make @Quy happy

* Update article.xml

* Remove space

* Update config.xml (#14)

* Update filter.xml (#15)

* Update config.xml (#16)

* Update profile.xml (#17)

* Update application.xml (#18)

* Update article.xml (#19)

* Update filter_articles.xml (#20)

* Update config.xml (#24)

* Update config.xml (#23)

* Update filter_fields.xml (#22)

* Update filter_featured.xml (#21)

* Update override.xml (#25)

* Update config.xml

* Update config.xml (#26)

* Update itemadmin_alias.xml (#30)

* Update itemadmin.xml (#29)

* Update item.xml (#27)

* Update item_alias.xml (#28)

* Update itemadmin_url.xml (#31)

* Update module.xml (#32)

* Update plugin.xml (#33)

* Update config.xml (#34)

* Update link.xml (#35)

* Update config.xml (#36)

* Update style.xml (#38)

* Update config.xml (#37)

* Update note.xml (#42)

* Update group.xml (#41)

* Update filter_debuggroup.xml (#40)

* Update config.xml (#39)

* corrections for @andrepereiradasilva

* gotya
infograf768 pushed a commit that referenced this pull request Sep 10, 2018
[Action logs] - component+plugin+module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants