Skip to content

feat(dynatrace-output): remove special handling from counters#9675

Merged
sspaink merged 8 commits intoinfluxdata:masterfrom
dynatrace-oss-contrib:dt-remove-counters
Sep 8, 2021
Merged

feat(dynatrace-output): remove special handling from counters#9675
sspaink merged 8 commits intoinfluxdata:masterfrom
dynatrace-oss-contrib:dt-remove-counters

Conversation

@dyladan
Copy link
Copy Markdown
Contributor

@dyladan dyladan commented Aug 24, 2021

Required for all PRs:

  • [ ] Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

Summary of Changes

  • Updated dynatrace metric util library
  • Removing handling for metric.Type() which is used by prometheus and statsd

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Aug 24, 2021
@dyladan dyladan force-pushed the dt-remove-counters branch from 0c6dcd9 to 269eb27 Compare August 24, 2021 21:28
arminru
arminru reviewed Aug 27, 2021
View reviewed changes
@arminru
Copy link
Copy Markdown
Contributor

arminru commented Aug 27, 2021

The bugfix included in this PR was already merged separately in #9676. Not sure how we can tell telegraf-tiger to remove the bugfix label again. This PR here should only go into 1.20.0 and not be backported to 1.19.x.

@srebhan srebhan added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins and removed fix pr to fix corresponding bug labels Sep 7, 2021
srebhan
srebhan reviewed Sep 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dyladan thanks for the PR! Only one minor suggestion in the code from my side. Would be nice if you can take a look.

@telegraf-tiger
Copy link
Copy Markdown
Contributor

telegraf-tiger bot commented Sep 7, 2021

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

srebhan
srebhan approved these changes Sep 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @dyladan for the contribution!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 8, 2021
@srebhan srebhan self-assigned this Sep 8, 2021
sspaink
sspaink approved these changes Sep 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sspaink sspaink merged commit 95ef674 into influxdata:master Sep 8, 2021
reimda pushed a commit that referenced this pull request Sep 17, 2021
@dyladan @arminru @reimda
feat(dynatrace-output): remove special handling from counters (#9675)
0083cc5 
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
(cherry picked from commit 95ef674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srebhan srebhan srebhan approved these changes

+2 more reviewers

@arminru arminru arminru left review comments

@sspaink sspaink sspaink approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srebhan srebhan

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dyladan @arminru @sspaink @srebhan