Fix memory leak in couchbase input#9544
Merged
MyaLongmire merged 2 commits intoinfluxdata:masterfrom Sep 7, 2021
Merged
Conversation
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
This was referenced Jul 27, 2021
ssoroka
reviewed
Aug 5, 2021
| if err != nil { | ||
| return err | ||
| } | ||
| defer pool.Close() |
Contributor
There was a problem hiding this comment.
why do we close the pool and not the connection? Also shouldn't we be reusing both?
Contributor
Author
There was a problem hiding this comment.
Ideally, we would be reusing both. However, if we reuse the pool, there is no way to refresh the bucket map, so we wouldn't be able to get metrics for new buckets, and we would start erroring if a bucket gets deleted.
We don't close the connection because there isn't a method to do that.
MyaLongmire
approved these changes
Sep 7, 2021
reimda
pushed a commit
that referenced
this pull request
Sep 17, 2021
(cherry picked from commit ba1484c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #9495
Fixes a memory leak in the
couchbaseplugin by closing all pools after they are done being used. The leak showed up after updating togo-couchbasev0.1.0 in #9412. It appears to be caused by circular references between buckets and their corresponding pools (I think this is the cause, I'm not entirely sure though).