Preserve precision on 64-bit integers#9520
Merged
sspaink merged 1 commit intoinfluxdata:masterfrom Jul 20, 2021
Merged
Conversation
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
sspaink
approved these changes
Jul 20, 2021
Contributor
sspaink
left a comment
There was a problem hiding this comment.
Great job! Thank you for fixing this.
reimda
pushed a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 2eb0ee2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #7555
Fixed a bug in
json_v2where precision would be lost onint64s anduint64s by changing how they are parsed from the source JSON. This could not be fixed in the originaljsonparser as there are no options for type conversions.Previously, an
int64oruint64would be converted from afloat64, which has a maximum of2^53 - 1as that is the max significant digits it can store, causing precision to be lost on anything larger. Now the values are parsed directly from the source content of the JSON.