Update json_v2 parser to handle null types#9368
Merged
reimda merged 3 commits intoinfluxdata:masterfrom Jun 15, 2021
Merged
Conversation
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
reimda
approved these changes
Jun 15, 2021
Contributor
reimda
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding so many good tests!
reimda
pushed a commit
that referenced
this pull request
Jun 17, 2021
(cherry picked from commit daec104)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: #9352
Instead of throwing an error when encountering a null type in the input JSON, I've updated the parser to ignore it because they are valid types but there isn't anything we can do with it. This follows the same behavior as the original json parser.