added a check for oid and name to prevent empty metrics#9366
Merged
Conversation
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
sspaink
approved these changes
Jun 16, 2021
reimda
pushed a commit
that referenced
this pull request
Jul 7, 2021
(cherry picked from commit b846c50)
Contributor
|
Did this pass all tests? Cause it makes telegraf to crash when you use ifName processor! |
Contributor
|
It did pass the tests, more disturbing is that the specific ifname test has been disabled in #8725 😱 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #8840 SNMP input can produce metrics with empty metric name
Added a check for empty oid and empty name
fixed an existing unit test to give the table a name
and added a test for a table with empty oid and empty name