Merged
Conversation
- export timestamps - enrich dimensions with OneAgent data - Add default dimensions feature
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Member
|
@dyladan may I ask why you remove those dimensions? Is there some problem? |
Member
|
Sorry wrong button. :-S |
Contributor
Author
No problem. Since this doesn't run in-process with the monitored application, we are having internal discussions as to whether or not the oneagent data enrichment makes sense in this context. I removed the commented code line to reduce confusion. |
Contributor
Author
|
It shouldn't block the PR since it can always be added later |
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
arminru
approved these changes
Jun 15, 2021
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
ssoroka
approved these changes
Jun 15, 2021
Contributor
ssoroka
left a comment
There was a problem hiding this comment.
I'm not sure about dt.metrics.source being a static dimension for all metrics, but it's not a blocker for me.
reimda
pushed a commit
that referenced
this pull request
Jul 28, 2021
- export timestamps - enrich dimensions with OneAgent data - Add default dimensions feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs: