Add s7comm external input plugin#9360
Merged
reimda merged 1 commit intoinfluxdata:masterfrom Jun 15, 2021
Merged
Conversation
srebhan
approved these changes
Jun 14, 2021
Member
srebhan
left a comment
There was a problem hiding this comment.
@nicolasme thanks for submitting this PR. I also skimmed over your plugin code and it looks quite nice and lean. Good job!
One thing that would be nice is to sort the list of external plugins alphabetically, but that might be a task for your next PR!?!? ;-P
Contributor
|
Thanks @nicolasme for the external plugin link! |
reimda
pushed a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 07778c5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #7728
Added external input plugin for Siemens PLC using golang library gos7
First ever contribution to open source project. All advice are welcome.