Add include_nodes filter for jenkins#9351
Merged
MyaLongmire merged 3 commits intoinfluxdata:masterfrom Jul 1, 2021
Merged
Conversation
e55b232 to
e92d900
Compare
Contributor
Author
|
@G0lang Would you be willing to test this? |
srebhan
requested changes
Jun 28, 2021
Member
srebhan
left a comment
There was a problem hiding this comment.
@akrantz01 thanks for this PR, it makes totally sense. However, you probably should use NewIncludeExcludeFilter() of the filter package which does the include/exclude handling for you and reduces the amount of code.
srebhan
approved these changes
Jun 29, 2021
Member
srebhan
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for also tackling jobFilter! I have just one minor comment in the code, but it is optional.
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
MyaLongmire
approved these changes
Jul 1, 2021
bhsu-ms
pushed a commit
to bhsu-ms/telegraf
that referenced
this pull request
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #9047
Adds the ability to explicitly include nodes for the
jenkins_nodemetric. Previously, you could only exclude nodes from being collected.Like the
job_excludeandjob_includefilters,node_excludetakes precedence overnode_includeif they are both present.