Fix Mac script to install go#9345
Merged
sspaink merged 7 commits intoinfluxdata:masterfrom Jun 10, 2021
Merged
Conversation
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Contributor
|
Looks good to me! 👍 👍 |
reimda
reviewed
Jun 9, 2021
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
reimda
suggested changes
Jun 9, 2021
Co-authored-by: reimda <reimda@users.noreply.github.com>
Contributor
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
reimda
added a commit
that referenced
this pull request
Jun 10, 2021
Co-authored-by: reimda <reimda@users.noreply.github.com> (cherry picked from commit 62715d1)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Aug 28, 2025
Co-authored-by: reimda <reimda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request caused a bug in the shell script to install Go for mac: #9335 causing the Mac build to fail currently: https://app.circleci.com/pipelines/github/influxdata/telegraf/5226/workflows/6e336a4d-749b-42fb-83d0-3cf0ba309879/jobs/95226. This wasn't caught in the pull request due to the script
check-file-changes.shwhich didn't run the CI if a shell script changed. Also updated thecheck-file-changes.shscript to take into consideration for release branches which was another issue with the script.@pierwill can you help verify that this change looks good?