Skip to content

Support new Suricata JSON format which includes arrays and strings#9338

Merged
sspaink merged 3 commits intoinfluxdata:masterfrom
sspaink:suricata
Jun 14, 2021
Merged

Support new Suricata JSON format which includes arrays and strings#9338
sspaink merged 3 commits intoinfluxdata:masterfrom
sspaink:suricata

Conversation

@sspaink
Copy link
Copy Markdown
Contributor

@sspaink sspaink commented Jun 8, 2021

  • Wrote appropriate unit tests.

resolves #9330

As described in #9330, the plugin didn't support array's in JSON being written by Suricata. I've updated the plugin to handle the case if an array or a string is encountered.

@masual
Copy link
Copy Markdown

masual commented Jun 9, 2021

Tested and working as expected, Thank you very much @sspaink !

@sspaink sspaink added the fix pr to fix corresponding bug label Jun 9, 2021
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan self-assigned this Jun 10, 2021
@srebhan srebhan added plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jun 10, 2021
@sspaink sspaink merged commit 1d4b8d6 into influxdata:master Jun 14, 2021
reimda pushed a commit that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Suricata Input Plugin] Error when enabling per thread statistics

4 participants