Skip to content

Add HTTP proxy to datadog output#9297

Merged
ssoroka merged 2 commits intoinfluxdata:masterfrom
akrantz01:8388-datadog-proxy
Jun 1, 2021
Merged

Add HTTP proxy to datadog output#9297
ssoroka merged 2 commits intoinfluxdata:masterfrom
akrantz01:8388-datadog-proxy

Conversation

@akrantz01
Copy link
Copy Markdown
Contributor

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #8388

Added configuring a HTTP proxy for the DataDog output through the config file.

@akrantz01 akrantz01 added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels May 24, 2021
## Write URL override; useful for debugging.
# url = "https://app.datadoghq.com/api/v1/series"

## Set http_proxy (telegraf uses the system wide proxy settings if it's is not set)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. Same in sampleConfig

Suggested change
## Set http_proxy (telegraf uses the system wide proxy settings if it's is not set)
## Set http_proxy (telegraf uses the system wide proxy settings if it isn't set)

Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akrantz01 thanks for adding this feature. I found two typos, but the change looks good code-wise.

@srebhan srebhan self-assigned this May 25, 2021
Copy link
Copy Markdown
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 27, 2021
@ssoroka ssoroka merged commit db0b6de into influxdata:master Jun 1, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add http_proxy config file support to datadog output plugin

3 participants